Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Unified Diff: components/suggestions/suggestions_service.cc

Issue 2558913003: Restrict transmission of external exp ids to signed in users. (Closed)
Patch Set: Address nit. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/suggestions/suggestions_service.cc
diff --git a/components/suggestions/suggestions_service.cc b/components/suggestions/suggestions_service.cc
index 47072e811b4356c16219bc1bccad12bbd57368ba..ec69cfe7af8ad7679c530b855ebc720a973569f9 100644
--- a/components/suggestions/suggestions_service.cc
+++ b/components/suggestions/suggestions_service.cc
@@ -420,8 +420,11 @@ std::unique_ptr<net::URLFetcher> SuggestionsService::CreateSuggestionsRequest(
request->SetRequestContext(url_request_context_);
// Add Chrome experiment state to the request headers.
net::HttpRequestHeaders headers;
+ // Note: It's fine to pass in |is_signed_in| false, which does not affect
+ // transmission of experiment ids coming from the variations server.
+ bool is_signed_in = false;
variations::AppendVariationHeaders(request->GetOriginalURL(), false, false,
- &headers);
+ is_signed_in, &headers);
request->SetExtraRequestHeaders(headers.ToString());
if (!access_token.empty()) {
request->AddExtraRequestHeader(
« no previous file with comments | « components/omnibox/browser/zero_suggest_provider.cc ('k') | components/variations/net/variations_http_headers.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698