Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Unified Diff: components/autofill/core/browser/autofill_download_manager.cc

Issue 2558913003: Restrict transmission of external exp ids to signed in users. (Closed)
Patch Set: Address nit. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/safe_browsing/srt_fetcher_win.cc ('k') | components/feedback/feedback_uploader_chrome.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/browser/autofill_download_manager.cc
diff --git a/components/autofill/core/browser/autofill_download_manager.cc b/components/autofill/core/browser/autofill_download_manager.cc
index 021a85024ea5a8908a029ff7fe1775f99860e926..331de9984500330b84b5a68b287e47b68a6b502d 100644
--- a/components/autofill/core/browser/autofill_download_manager.cc
+++ b/components/autofill/core/browser/autofill_download_manager.cc
@@ -247,8 +247,12 @@ bool AutofillDownloadManager::StartRequest(
net::LOAD_DO_NOT_SEND_COOKIES);
// Add Chrome experiment state to the request headers.
net::HttpRequestHeaders headers;
- variations::AppendVariationHeaders(
- fetcher->GetOriginalURL(), driver_->IsOffTheRecord(), false, &headers);
+ // Note: It's fine to pass in |is_signed_in| false, which does not affect
+ // transmission of experiment ids coming from the variations server.
+ bool is_signed_in = false;
+ variations::AppendVariationHeaders(fetcher->GetOriginalURL(),
+ driver_->IsOffTheRecord(), false,
+ is_signed_in, &headers);
fetcher->SetExtraRequestHeaders(headers.ToString());
fetcher->Start();
« no previous file with comments | « chrome/browser/safe_browsing/srt_fetcher_win.cc ('k') | components/feedback/feedback_uploader_chrome.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698