Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Side by Side Diff: tools/perf/benchmarks/media.py

Issue 2558893002: [Telemetry] Disable android media test on non android platforms. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from core import perf_benchmark 5 from core import perf_benchmark
6 6
7 from telemetry import benchmark 7 from telemetry import benchmark
8 from telemetry.page import legacy_page_test 8 from telemetry.page import legacy_page_test
9 from telemetry.value import list_of_scalar_values 9 from telemetry.value import list_of_scalar_values
10 from telemetry.value import scalar 10 from telemetry.value import scalar
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 class MediaAndroid(perf_benchmark.PerfBenchmark): 78 class MediaAndroid(perf_benchmark.PerfBenchmark):
79 """Obtains media metrics for key user scenarios on Android.""" 79 """Obtains media metrics for key user scenarios on Android."""
80 test = media.Media 80 test = media.Media
81 tag = 'android' 81 tag = 'android'
82 page_set = page_sets.ToughVideoCasesPageSet 82 page_set = page_sets.ToughVideoCasesPageSet
83 # Exclude is_4k and 50 fps media files (garden* & crowd*). 83 # Exclude is_4k and 50 fps media files (garden* & crowd*).
84 options = {'story_label_filter_exclude': 'is_4k,is_50fps'} 84 options = {'story_label_filter_exclude': 'is_4k,is_50fps'}
85 85
86 @classmethod 86 @classmethod
87 def ShouldDisable(cls, possible_browser): 87 def ShouldDisable(cls, possible_browser):
88 # crbug.com/672059
89 if possible_browser.platform.GetOSName() != "android":
90 return True
88 # crbug.com/448092 91 # crbug.com/448092
89 if cls.IsSvelte(possible_browser): 92 if cls.IsSvelte(possible_browser):
90 return True 93 return True
91 94
92 # crbug.com/647372 95 # crbug.com/647372
93 if possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X': 96 if possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X':
94 return True 97 return True
95 98
96 return False 99 return False
97 100
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 147
145 @classmethod 148 @classmethod
146 def Name(cls): 149 def Name(cls):
147 return 'media.mse_cases' 150 return 'media.mse_cases'
148 151
149 def SetExtraBrowserOptions(self, options): 152 def SetExtraBrowserOptions(self, options):
150 # Needed to allow XHR requests to return stream objects. 153 # Needed to allow XHR requests to return stream objects.
151 options.AppendExtraBrowserArgs( 154 options.AppendExtraBrowserArgs(
152 ['--enable-experimental-web-platform-features', 155 ['--enable-experimental-web-platform-features',
153 '--disable-gesture-requirement-for-media-playback']) 156 '--disable-gesture-requirement-for-media-playback'])
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698