Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Issue 2558853003: Use strong references from WebGLContextGroup to WebGLRenderingContextBase. (Closed)

Created:
4 years ago by Ken Russell (switch to Gerrit)
Modified:
4 years ago
CC:
chromium-reviews, blink-reviews, Zhenyao Mo
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use strong references from WebGLContextGroup to WebGLRenderingContextBase. Making the Oilpan references weak but the V8 wrapper references strong is causing confusion at least, and bugs at worst. Not clear this will fix the referenced bug, but should do no harm. BUG=671791 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/aa5cbb1a6f3500536feec0c97acdd72e1c56dbb4 Cr-Commit-Position: refs/heads/master@{#437183}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -21 lines) Patch
M third_party/WebKit/Source/modules/webgl/WebGLContextGroup.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLContextGroup.cpp View 2 chunks +3 lines, -18 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Ken Russell (switch to Gerrit)
haraken or mlippautz: please review this and CQ it if it looks good. I'd like ...
4 years ago (2016-12-08 01:51:11 UTC) #3
haraken
LGTM
4 years ago (2016-12-08 01:52:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2558853003/1
4 years ago (2016-12-08 01:54:50 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 05:01:00 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-08 05:04:31 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aa5cbb1a6f3500536feec0c97acdd72e1c56dbb4
Cr-Commit-Position: refs/heads/master@{#437183}

Powered by Google App Engine
This is Rietveld 408576698