Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Unified Diff: chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc

Issue 2558843002: Public Sessions - prompt the user for tabCapture requests (Closed)
Patch Set: Updated comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc
diff --git a/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc b/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc
index ec4db9cd464dfba754cae40fd8a4cdd8b1906930..8ada0f4ebfd202438bff5c7df93514f413979936 100644
--- a/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc
+++ b/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc
@@ -451,9 +451,10 @@ const char* const kSafePermissionStrings[] = {
// access to page content, which we can't allow.
// "declarativeContent",
- // Allow, but either (1) ask user for confirmation or (2) return blank
- // capture.
- // "desktopCapture",
+ // User is prompted when an extension requests desktopCapture whether they
+ // want to allow it. The request is made through
+ // chrome.desktopCapture.chooseDesktopMedia call.
+ "desktopCapture",
Sergey Ulanov 2016/12/08 05:10:35 Please mention this change in the CL description.
Ivan Šandrk 2016/12/08 14:10:25 Done.
// Haven't checked in detail what this does, but messing with devtools
// usually comes with the ability to access page content.
@@ -626,9 +627,9 @@ const char* const kSafePermissionStrings[] = {
// Enumerates removable storage.
"system.storage",
- // Provides access to screen contents, so block. Alternatively, (1) prompt
- // for user consent or (2) return blank capture.
- // "tabCapture",
+ // User is prompted (allow/deny) when an extension requests tabCapture. The
+ // request is made via chrome.tabCapture.capture call.
+ "tabCapture",
// Privacy sensitive URL access.
// "tabs",

Powered by Google App Engine
This is Rietveld 408576698