Issue 255883002: ARM: don't use r9 anymore for gap resolution

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 255883002: ARM: don't use r9 anymore for gap resolution (Closed)

Created:
6 years, 8 months ago by vincent.belliard

Modified:
6 years, 7 months ago

Reviewers:
Benedikt Meurer, ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

ARM: don't use r9 anymore for gap resolution BUG= R=ulan@chromium.org, bmeurer@chromium.org

Patch Set 2 : rename kSavedValue #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -32 lines)			Patch
	M	src/arm/lithium-gap-resolver-arm.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	src/arm/lithium-gap-resolver-arm.cc	View	1	7 chunks	+39 lines, -32 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

vincent.belliard

Release r9 from gap resolver to be able, in a next patch, to give back ...

6 years, 8 months ago (2014-04-25 13:49:24 UTC) #1

Benedikt Meurer

LGTM with nit. https://codereview.chromium.org/255883002/diff/1/src/arm/lithium-gap-resolver-arm.cc File src/arm/lithium-gap-resolver-arm.cc (right): https://codereview.chromium.org/255883002/diff/1/src/arm/lithium-gap-resolver-arm.cc#newcode43 src/arm/lithium-gap-resolver-arm.cc:43: #define kSavedValue kRootRegister Nit: Use kSavedValueRegister.

6 years, 8 months ago (2014-04-26 10:14:38 UTC) #2