Don't check 'visibility' in LayoutSVGResourceMasker

Don't check 'visibility' in LayoutSVGResourceMasker

Since 'visibility' does not work in the same way as 'display', it's not
possible to "prune" subtrees based on non-'visible' values of the
property. Remove the check from the two methods that use it, and leave
to lower levels to handle it.

BUG=672055
Committed: https://crrev.com/51a75fa55ba71462963ddcf085995cf3eca66104
Cr-Commit-Position: refs/heads/master@{#436996}

[fs, 2016-12-07 12:57:39]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 12:58:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2016-12-07 14:14:06]

Description was changed from

==========
Don't check 'visibility' in LayoutSVGResourceMasker

Since 'visibility' does not work in the same way as 'display', it's not
possible to "prune" subtrees based on non-'visible' values of the
property. Remove the check from the two methods that use it, and leave
to lower levels to handle it.
==========

to

==========
Don't check 'visibility' in LayoutSVGResourceMasker

Since 'visibility' does not work in the same way as 'display', it's not
possible to "prune" subtrees based on non-'visible' values of the
property. Remove the check from the two methods that use it, and leave
to lower levels to handle it.

BUG=672055
==========

[fs, 2016-12-07 14:14:18]

fs@opera.com changed reviewers:
+ fmalita@chromium.org, schenney@chromium.org

[commit-bot: I haz the power, 2016-12-07 14:21:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 14:21:02]

Dry run: This issue passed the CQ dry run.

[f(malita), 2016-12-07 14:29:42]

LGTM

https://codereview.chromium.org/2558793002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/svg/masking/mask-with-visibility-hidden-group.html
(right):

https://codereview.chromium.org/2558793002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/masking/mask-with-visibility-hidden-group.html:5:
<rect width="100" height="100" fill="white" visibility="visible"/>
Can we add a

  <rect width="200" height="100" fill="white"/>

(expected to "inherit" the hidden visibility and not draw)?

[fs, 2016-12-07 15:18:00]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 15:18:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2016-12-07 15:18:33]

https://codereview.chromium.org/2558793002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/svg/masking/mask-with-visibility-hidden-group.html
(right):

https://codereview.chromium.org/2558793002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/masking/mask-with-visibility-hidden-group.html:5:
<rect width="100" height="100" fill="white" visibility="visible"/>
On 2016/12/07 at 14:29:41, f(malita) wrote:
> Can we add a
> 
>   <rect width="200" height="100" fill="white"/>
> 
> (expected to "inherit" the hidden visibility and not draw)?

Sure, done.

[commit-bot: I haz the power, 2016-12-07 15:25:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 15:25:17]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fs, 2016-12-07 17:06:22]

The CQ bit was checked by fs@opera.com

[fs, 2016-12-07 17:06:22]

The patchset sent to the CQ was uploaded after l-g-t-m from fmalita@chromium.org
Link to the patchset: https://codereview.chromium.org/2558793002/#ps20001
(title: "Adjust test")

[commit-bot: I haz the power, 2016-12-07 17:06:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 17:45:39]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481130382491510,
"parent_rev": "6c38bb26440b91998690088718a717887b1cab84", "commit_rev":
"4a342159f3959b6a92c4c623b61e71e3f15b07a9"}

[commit-bot: I haz the power, 2016-12-07 17:46:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-07 17:48:07]

Description was changed from

==========
Don't check 'visibility' in LayoutSVGResourceMasker

Since 'visibility' does not work in the same way as 'display', it's not
possible to "prune" subtrees based on non-'visible' values of the
property. Remove the check from the two methods that use it, and leave
to lower levels to handle it.

BUG=672055
==========

to

==========
Don't check 'visibility' in LayoutSVGResourceMasker

Since 'visibility' does not work in the same way as 'display', it's not
possible to "prune" subtrees based on non-'visible' values of the
property. Remove the check from the two methods that use it, and leave
to lower levels to handle it.

BUG=672055

Committed: https://crrev.com/51a75fa55ba71462963ddcf085995cf3eca66104
Cr-Commit-Position: refs/heads/master@{#436996}
==========

[commit-bot: I haz the power, 2016-12-07 17:48:08]

Patchset 2 (id:??) landed as
https://crrev.com/51a75fa55ba71462963ddcf085995cf3eca66104
Cr-Commit-Position: refs/heads/master@{#436996}