Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 2558773002: Remove ContextLifecycleObserver from WaitUntilObserver (Closed)

Created:
4 years ago by haraken
Modified:
4 years ago
Reviewers:
nhiroki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, nhiroki, haraken, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ContextLifecycleObserver from WaitUntilObserver WaitUntilObserver inherits from ContextLifecycleObserver just to keep track of its associated ExecutionContext. It should just hold a strong member to ExecutionContext. BUG=610176 Committed: https://crrev.com/aff908ab80d22abb30c09624bf13fec0cbc38490 Cr-Commit-Position: refs/heads/master@{#437171}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -14 lines) Patch
M third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.h View 3 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp View 5 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
haraken
PTAL
4 years ago (2016-12-07 11:27:24 UTC) #2
nhiroki
lgtm
4 years ago (2016-12-08 02:11:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2558773002/1
4 years ago (2016-12-08 02:21:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 04:01:13 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-08 04:03:38 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aff908ab80d22abb30c09624bf13fec0cbc38490
Cr-Commit-Position: refs/heads/master@{#437171}

Powered by Google App Engine
This is Rietveld 408576698