Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2558763003: Move hasRuntimeTypeSupport, hasIsolateSupport, and hasFunctionApplySupport to JavaScriptBackend. (Closed)

Created:
4 years ago by Johnni Winther
Modified:
4 years ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move hasRuntimeTypeSupport, hasIsolateSupport, and hasFunctionApplySupport to JavaScriptBackend. R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/709a355284ab49dbff3367e9828a7df7ed82f6fb

Patch Set 1 #

Patch Set 2 : Cleanup. #

Total comments: 2

Patch Set 3 : Updated cf. comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -91 lines) Patch
M pkg/compiler/lib/src/common/backend_api.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/common/names.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 2 chunks +1 line, -8 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 7 chunks +1 line, -42 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 2 5 chunks +54 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/main_call_stub_generator.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/universe/world_builder.dart View 3 chunks +3 lines, -12 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/serialization/model_test_helper.dart View 1 chunk +8 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years ago (2016-12-07 11:44:24 UTC) #2
Harry Terkelsen
lgtm https://codereview.chromium.org/2558763003/diff/20001/pkg/compiler/lib/src/js_backend/backend.dart File pkg/compiler/lib/src/js_backend/backend.dart (right): https://codereview.chromium.org/2558763003/diff/20001/pkg/compiler/lib/src/js_backend/backend.dart#newcode1858 pkg/compiler/lib/src/js_backend/backend.dart:1858: if (!hasIsolateSupport && (!element.isField || !element.isConst)) { just ...
4 years ago (2016-12-07 21:08:54 UTC) #3
Johnni Winther
https://codereview.chromium.org/2558763003/diff/20001/pkg/compiler/lib/src/js_backend/backend.dart File pkg/compiler/lib/src/js_backend/backend.dart (right): https://codereview.chromium.org/2558763003/diff/20001/pkg/compiler/lib/src/js_backend/backend.dart#newcode1858 pkg/compiler/lib/src/js_backend/backend.dart:1858: if (!hasIsolateSupport && (!element.isField || !element.isConst)) { On 2016/12/07 ...
4 years ago (2016-12-08 09:04:50 UTC) #4
Johnni Winther
4 years ago (2016-12-08 09:08:31 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
709a355284ab49dbff3367e9828a7df7ed82f6fb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698