Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: android_webview/browser/browser_view_renderer.h

Issue 2558763002: aw: Fix race between first frame draw and view detach causing deadlock. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/browser/render_thread_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/browser_view_renderer.h
diff --git a/android_webview/browser/browser_view_renderer.h b/android_webview/browser/browser_view_renderer.h
index 7882f8097c7fd3ff55055c0f557b187399bf3033..24e22781e9dc79405df4f70509a05180ce235f28 100644
--- a/android_webview/browser/browser_view_renderer.h
+++ b/android_webview/browser/browser_view_renderer.h
@@ -204,7 +204,11 @@ class BrowserViewRenderer : public content::SynchronousCompositorClient,
bool offscreen_pre_raster_;
// Must do a synchronous draw first to ensure GL bindings are initialized.
- // TODO(boliu): Wait on render thread and remove this.
+ // TODO(boliu): Wait on render thread and remove this. When the
+ // first synchronous draw requirement is removed,
+ // RenderThreadManager::DeleteHardwareRendererOnUI will need to
+ // change, because it will no longer be true that having received a
+ // frame means that GL bindings have been initialized.
bool allow_async_draw_;
gfx::Vector2d last_on_draw_scroll_offset_;
« no previous file with comments | « no previous file | android_webview/browser/render_thread_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698