Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 255873003: Use base::STLSet* in place of std::set_* for simplicity. (Closed)

Created:
6 years, 8 months ago by Sungmann Cho
Modified:
6 years, 7 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Use base::STLSet* in place of std::set_* for simplicity. BUG=254066 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266842

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -23 lines) Patch
M extensions/common/permissions/set_disjunction_permission.h View 5 chunks +8 lines, -23 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
Sungmann Cho
Please take a look. Thanks.
6 years, 8 months ago (2014-04-25 13:49:10 UTC) #1
Sungmann Cho
ping...
6 years, 7 months ago (2014-04-28 18:34:30 UTC) #2
benwells
lgtm
6 years, 7 months ago (2014-04-29 00:15:31 UTC) #3
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 7 months ago (2014-04-29 00:27:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/255873003/1
6 years, 7 months ago (2014-04-29 00:28:06 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 00:32:15 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 7 months ago (2014-04-29 00:32:16 UTC) #7
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 7 months ago (2014-04-29 03:18:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/255873003/1
6 years, 7 months ago (2014-04-29 03:19:14 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 04:00:37 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 7 months ago (2014-04-29 04:00:37 UTC) #11
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 7 months ago (2014-04-29 05:38:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/255873003/1
6 years, 7 months ago (2014-04-29 05:39:50 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 06:21:13 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 7 months ago (2014-04-29 06:21:14 UTC) #15
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 7 months ago (2014-04-29 06:29:01 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/255873003/1
6 years, 7 months ago (2014-04-29 06:29:42 UTC) #17
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 11:08:50 UTC) #18
Message was sent while issue was closed. 
Change committed as 266842

Powered by Google App Engine
This is Rietveld 408576698