Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 255873002: Revert of Add ScopedStubEnterpriseInstallAttributes for tests to set test install attributes. (Closed)

Created:
6 years, 8 months ago by Alexander Potapenko
Modified:
6 years, 8 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org, merkulova
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Add ScopedStubEnterpriseInstallAttributes for tests to set test install attributes. (https://codereview.chromium.org/247283007/) Reason for revert: The CL has caused memory leaks on the CrOS ASan bots originating from policy::DeviceStatusCollectorTest. Original issue's description: > Add ScopedStubEnterpriseInstallAttributes for tests to set test install attributes. > > This change is motivated by the need to set the test install attributes before the browser policy connector is initialized for the first time. In particular, test class members may cause the policy connector to be initialized in their constructors, so we also need to set the install attributes in the constructor of a member. > > BUG=243341 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266094 TBR=mnissler@chromium.org,stepco@chromium.org NOTREECHECKS=true NOTRY=true BUG=243341

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -36 lines) Patch
M chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_status_collector_browsertest.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/policy/stub_enterprise_install_attributes.h View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/policy/stub_enterprise_install_attributes.cc View 2 chunks +0 lines, -20 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Alexander Potapenko
Created Revert of Add ScopedStubEnterpriseInstallAttributes for tests to set test install attributes.
6 years, 8 months ago (2014-04-25 12:41:08 UTC) #1
Alexander Potapenko
The CQ bit was unchecked by glider@chromium.org
6 years, 8 months ago (2014-04-25 12:42:02 UTC) #2
Alexander Potapenko
The CQ bit was checked by glider@chromium.org
6 years, 8 months ago (2014-04-25 12:42:03 UTC) #3
Mattias Nissler (ping if slow)
LGTM. Please note that https://codereview.chromium.org/228553002/ is in the CQ right now, which depends on this. ...
6 years, 8 months ago (2014-04-25 12:44:45 UTC) #4
Alexander Potapenko
On 2014/04/25 12:44:45, Mattias Nissler wrote: > LGTM. Please note that https://codereview.chromium.org/228553002/ is in the ...
6 years, 8 months ago (2014-04-25 12:47:58 UTC) #5
Alexander Potapenko
The CQ bit was unchecked by glider@chromium.org
6 years, 8 months ago (2014-04-25 12:54:37 UTC) #6
Alexander Potapenko
6 years, 8 months ago (2014-04-25 12:54:51 UTC) #7
On 2014/04/25 12:54:37, Alexander Potapenko wrote:
> The CQ bit was unchecked by mailto:glider@chromium.org

Reverted using drover

Powered by Google App Engine
This is Rietveld 408576698