Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 2558703003: MD History: Fix loading of history results in background tabs (Closed)

Created:
4 years ago by tsergeant
Modified:
4 years ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Fix loading of history results in background tabs When reloading the history page in a background tab, it was possible for results to arrive before the page was fully initialized and the <iron-pages> element knew which type of history list should be used. This replaces the list selection code with a direct selector, removing the dependency on <iron-pages> startup from page initialization. BUG=671960 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/546b09b2e48f471fd08f991d477c952689ad8b99 Cr-Commit-Position: refs/heads/master@{#437197}

Patch Set 1 #

Patch Set 2 : Closure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M chrome/browser/resources/md_history/app.crisper.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/app.vulcanized.html View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_history/list_container.js View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
tsergeant
4 years ago (2016-12-07 23:16:48 UTC) #5
calamity
lgtm.
4 years ago (2016-12-08 04:55:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2558703003/20001
4 years ago (2016-12-08 06:12:27 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-08 06:38:31 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-08 06:40:26 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/546b09b2e48f471fd08f991d477c952689ad8b99
Cr-Commit-Position: refs/heads/master@{#437197}

Powered by Google App Engine
This is Rietveld 408576698