Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4103)

Unified Diff: chrome/browser/chrome_quota_permission_context.cc

Issue 2558673003: Move RequestQuotaPermission from RenderView to RenderFrame. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/child/quota_dispatcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_quota_permission_context.cc
diff --git a/chrome/browser/chrome_quota_permission_context.cc b/chrome/browser/chrome_quota_permission_context.cc
index fdf385af33162e0a1ee215bbccdb568d870d93a6..986dfbaf54c886fd2ff35e73ad93fc1436e91f02 100644
--- a/chrome/browser/chrome_quota_permission_context.cc
+++ b/chrome/browser/chrome_quota_permission_context.cc
@@ -254,13 +254,12 @@ void ChromeQuotaPermissionContext::RequestQuotaPermission(
return;
}
- content::WebContents* web_contents =
- tab_util::GetWebContentsByID(render_process_id,
- params.render_view_id);
+ content::WebContents* web_contents = tab_util::GetWebContentsByFrameID(
+ render_process_id, params.render_frame_id);
if (!web_contents) {
// The tab may have gone away or the request may not be from a tab.
LOG(WARNING) << "Attempt to request quota tabless renderer: "
- << render_process_id << "," << params.render_view_id;
+ << render_process_id << "," << params.render_frame_id;
DispatchCallbackOnIOThread(callback, QUOTA_PERMISSION_RESPONSE_CANCELLED);
return;
}
@@ -286,7 +285,7 @@ void ChromeQuotaPermissionContext::RequestQuotaPermission(
// The tab has no UI service for presenting the permissions request.
LOG(WARNING) << "Attempt to request quota from a background page: "
- << render_process_id << "," << params.render_view_id;
+ << render_process_id << "," << params.render_frame_id;
DispatchCallbackOnIOThread(callback, QUOTA_PERMISSION_RESPONSE_CANCELLED);
}
« no previous file with comments | « no previous file | content/child/quota_dispatcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698