|
|
Chromium Code Reviews|
Created:
4 years ago by nhiroki Modified:
4 years ago CC:
chromium-reviews, shimazu+worker_chromium.org, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, blink-worker-reviews_chromium.org, ikilpatrick, Rick Byers Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionWorker: Enable UseCounter for MainThreadWorkletGlobalScope
API use on the MainThreadWorkletGlobalScope is recorded in parent Document's
UseCounter.
Note that MainThreadWorklets (PaintWorklets) hasn't been shipped yet and this
should not affect use counts in the real world.
BUG=667357
Committed: https://crrev.com/e242f18b14ead9fc05efcb33f9bae69c312a33fa
Cr-Commit-Position: refs/heads/master@{#437222}
Patch Set 1 #
Total comments: 2
Patch Set 2 : fix KURL #
Messages
Total messages: 32 (25 generated)
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Description was changed from ========== Worker: Enable UseCounter for MainThreadWorkletGlobalScope BUG=667357 ========== to ========== Worker: Enable UseCounter for MainThreadWorkletGlobalScope Note that MainThreadWorklets (PaintWorklets) hasn't been shiped yet and this should not affect use counts in the real world. BUG=667357 ==========
nhiroki@chromium.org changed reviewers: + falken@chromium.org, haraken@chromium.org
PTAL, thanks!
Description was changed from ========== Worker: Enable UseCounter for MainThreadWorkletGlobalScope Note that MainThreadWorklets (PaintWorklets) hasn't been shiped yet and this should not affect use counts in the real world. BUG=667357 ========== to ========== Worker: Enable UseCounter for MainThreadWorkletGlobalScope Note that MainThreadWorklets (PaintWorklets) hasn't been shiped yet and this should not affect use counts in the real world. BUG=667357 ==========
Description was changed from ========== Worker: Enable UseCounter for MainThreadWorkletGlobalScope Note that MainThreadWorklets (PaintWorklets) hasn't been shiped yet and this should not affect use counts in the real world. BUG=667357 ========== to ========== Worker: Enable UseCounter for MainThreadWorkletGlobalScope API use on the MainThreadWorkletGLobalScope is recored in parent Document's UseCounter. Note that MainThreadWorklets (PaintWorklets) hasn't been shiped yet and this should not affect use counts in the real world. BUG=667357 ==========
Description was changed from ========== Worker: Enable UseCounter for MainThreadWorkletGlobalScope API use on the MainThreadWorkletGLobalScope is recored in parent Document's UseCounter. Note that MainThreadWorklets (PaintWorklets) hasn't been shiped yet and this should not affect use counts in the real world. BUG=667357 ========== to ========== Worker: Enable UseCounter for MainThreadWorkletGlobalScope API use on the MainThreadWorkletGLobalScope is recored in parent Document's UseCounter. Note that MainThreadWorklets (PaintWorklets) hasn't been shiped yet and this should not affect use counts in the real world. BUG=667357 ==========
Description was changed from ========== Worker: Enable UseCounter for MainThreadWorkletGlobalScope API use on the MainThreadWorkletGLobalScope is recored in parent Document's UseCounter. Note that MainThreadWorklets (PaintWorklets) hasn't been shiped yet and this should not affect use counts in the real world. BUG=667357 ========== to ========== Worker: Enable UseCounter for MainThreadWorkletGlobalScope API use on the MainThreadWorkletGlobalScope is recored in parent Document's UseCounter. Note that MainThreadWorklets (PaintWorklets) hasn't been shiped yet and this should not affect use counts in the real world. BUG=667357 ==========
Description was changed from ========== Worker: Enable UseCounter for MainThreadWorkletGlobalScope API use on the MainThreadWorkletGlobalScope is recored in parent Document's UseCounter. Note that MainThreadWorklets (PaintWorklets) hasn't been shiped yet and this should not affect use counts in the real world. BUG=667357 ========== to ========== Worker: Enable UseCounter for MainThreadWorkletGlobalScope API use on the MainThreadWorkletGlobalScope is recorded in parent Document's UseCounter. Note that MainThreadWorklets (PaintWorklets) hasn't been shiped yet and this should not affect use counts in the real world. BUG=667357 ==========
lgtm https://codereview.chromium.org/2558643005/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/workers/MainThreadWorkletTest.cpp (right): https://codereview.chromium.org/2558643005/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/workers/MainThreadWorkletTest.cpp:16: KURL url = KURL(ParsedURLString, "https://example.com/"); nit: KURL url(ParsedURLString, ...)?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
LGTM
Thank you. https://codereview.chromium.org/2558643005/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/workers/MainThreadWorkletTest.cpp (right): https://codereview.chromium.org/2558643005/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/workers/MainThreadWorkletTest.cpp:16: KURL url = KURL(ParsedURLString, "https://example.com/"); On 2016/12/08 05:32:27, falken wrote: > nit: KURL url(ParsedURLString, ...)? Done.
The CQ bit was checked by nhiroki@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org, haraken@chromium.org Link to the patchset: https://codereview.chromium.org/2558643005/#ps60001 (title: "fix KURL")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Worker: Enable UseCounter for MainThreadWorkletGlobalScope API use on the MainThreadWorkletGlobalScope is recorded in parent Document's UseCounter. Note that MainThreadWorklets (PaintWorklets) hasn't been shiped yet and this should not affect use counts in the real world. BUG=667357 ========== to ========== Worker: Enable UseCounter for MainThreadWorkletGlobalScope API use on the MainThreadWorkletGlobalScope is recorded in parent Document's UseCounter. Note that MainThreadWorklets (PaintWorklets) hasn't been shipped yet and this should not affect use counts in the real world. BUG=667357 ==========
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481180261409890,
"parent_rev": "996f65962a12d5d4ee65faca2457555c672dd6ab", "commit_rev":
"78f64c07a03600273c2b85ba7cbc66859bfcf0d3"}
Message was sent while issue was closed.
Description was changed from ========== Worker: Enable UseCounter for MainThreadWorkletGlobalScope API use on the MainThreadWorkletGlobalScope is recorded in parent Document's UseCounter. Note that MainThreadWorklets (PaintWorklets) hasn't been shipped yet and this should not affect use counts in the real world. BUG=667357 ========== to ========== Worker: Enable UseCounter for MainThreadWorkletGlobalScope API use on the MainThreadWorkletGlobalScope is recorded in parent Document's UseCounter. Note that MainThreadWorklets (PaintWorklets) hasn't been shipped yet and this should not affect use counts in the real world. BUG=667357 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Worker: Enable UseCounter for MainThreadWorkletGlobalScope API use on the MainThreadWorkletGlobalScope is recorded in parent Document's UseCounter. Note that MainThreadWorklets (PaintWorklets) hasn't been shipped yet and this should not affect use counts in the real world. BUG=667357 ========== to ========== Worker: Enable UseCounter for MainThreadWorkletGlobalScope API use on the MainThreadWorkletGlobalScope is recorded in parent Document's UseCounter. Note that MainThreadWorklets (PaintWorklets) hasn't been shipped yet and this should not affect use counts in the real world. BUG=667357 Committed: https://crrev.com/e242f18b14ead9fc05efcb33f9bae69c312a33fa Cr-Commit-Position: refs/heads/master@{#437222} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/e242f18b14ead9fc05efcb33f9bae69c312a33fa Cr-Commit-Position: refs/heads/master@{#437222} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
