Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 2558643005: Worker: Enable UseCounter for MainThreadWorkletGlobalScope (Closed)

Created:
4 years ago by nhiroki
Modified:
4 years ago
Reviewers:
falken, haraken
CC:
chromium-reviews, shimazu+worker_chromium.org, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, blink-worker-reviews_chromium.org, ikilpatrick, Rick Byers
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Worker: Enable UseCounter for MainThreadWorkletGlobalScope API use on the MainThreadWorkletGlobalScope is recorded in parent Document's UseCounter. Note that MainThreadWorklets (PaintWorklets) hasn't been shipped yet and this should not affect use counts in the real world. BUG=667357 Committed: https://crrev.com/e242f18b14ead9fc05efcb33f9bae69c312a33fa Cr-Commit-Position: refs/heads/master@{#437222}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix KURL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -17 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp View 1 chunk +8 lines, -6 lines 0 comments Download
A third_party/WebKit/Source/core/workers/MainThreadWorkletTest.cpp View 1 1 chunk +54 lines, -0 lines 0 comments Download

Messages

Total messages: 32 (25 generated)
nhiroki
PTAL, thanks!
4 years ago (2016-12-08 05:11:27 UTC) #13
falken
lgtm https://codereview.chromium.org/2558643005/diff/40001/third_party/WebKit/Source/core/workers/MainThreadWorkletTest.cpp File third_party/WebKit/Source/core/workers/MainThreadWorkletTest.cpp (right): https://codereview.chromium.org/2558643005/diff/40001/third_party/WebKit/Source/core/workers/MainThreadWorkletTest.cpp#newcode16 third_party/WebKit/Source/core/workers/MainThreadWorkletTest.cpp:16: KURL url = KURL(ParsedURLString, "https://example.com/"); nit: KURL url(ParsedURLString, ...
4 years ago (2016-12-08 05:32:28 UTC) #19
haraken
LGTM
4 years ago (2016-12-08 06:53:07 UTC) #22
nhiroki
Thank you. https://codereview.chromium.org/2558643005/diff/40001/third_party/WebKit/Source/core/workers/MainThreadWorkletTest.cpp File third_party/WebKit/Source/core/workers/MainThreadWorkletTest.cpp (right): https://codereview.chromium.org/2558643005/diff/40001/third_party/WebKit/Source/core/workers/MainThreadWorkletTest.cpp#newcode16 third_party/WebKit/Source/core/workers/MainThreadWorkletTest.cpp:16: KURL url = KURL(ParsedURLString, "https://example.com/"); On 2016/12/08 ...
4 years ago (2016-12-08 06:57:33 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2558643005/60001
4 years ago (2016-12-08 06:58:00 UTC) #26
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years ago (2016-12-08 09:56:45 UTC) #30
commit-bot: I haz the power
4 years ago (2016-12-08 09:58:35 UTC) #32
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e242f18b14ead9fc05efcb33f9bae69c312a33fa
Cr-Commit-Position: refs/heads/master@{#437222}

Powered by Google App Engine
This is Rietveld 408576698