Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2558643004: Remove ContextLifecycleObserver from PresentationConnectionList (Closed)

Created:
4 years ago by haraken
Modified:
4 years ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ContextLifecycleObserver from PresentationConnectionList Currently PresentationConnectionList is inheriting from ContextLifecycleObserver just to implement EventTarget::getExecutionContext(). Instead, PresentationConnectionList should just hold a strong member to ExecutionContext. BUG=610176 Committed: https://crrev.com/3a0ebdbbfbde6acd2782c30671d42292740762f7 Cr-Commit-Position: refs/heads/master@{#436901}

Patch Set 1 #

Total comments: 2

Patch Set 2 : temp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -11 lines) Patch
M third_party/WebKit/Source/modules/presentation/PresentationConnectionList.h View 1 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationConnectionList.cpp View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
haraken
PTAL https://codereview.chromium.org/2558643004/diff/1/third_party/WebKit/Source/modules/presentation/PresentationConnectionList.h File third_party/WebKit/Source/modules/presentation/PresentationConnectionList.h (right): https://codereview.chromium.org/2558643004/diff/1/third_party/WebKit/Source/modules/presentation/PresentationConnectionList.h#newcode53 third_party/WebKit/Source/modules/presentation/PresentationConnectionList.h:53: Member<ExecutionContext> m_executionContext; Before this CL, it was a ...
4 years ago (2016-12-07 07:37:10 UTC) #2
sof
lgtm https://codereview.chromium.org/2558643004/diff/1/third_party/WebKit/Source/modules/presentation/PresentationConnectionList.h File third_party/WebKit/Source/modules/presentation/PresentationConnectionList.h (right): https://codereview.chromium.org/2558643004/diff/1/third_party/WebKit/Source/modules/presentation/PresentationConnectionList.h#newcode8 third_party/WebKit/Source/modules/presentation/PresentationConnectionList.h:8: #include "core/dom/ContextLifecycleObserver.h" Unused
4 years ago (2016-12-07 07:42:12 UTC) #3
haraken
On 2016/12/07 07:42:12, sof wrote: > lgtm > > https://codereview.chromium.org/2558643004/diff/1/third_party/WebKit/Source/modules/presentation/PresentationConnectionList.h > File third_party/WebKit/Source/modules/presentation/PresentationConnectionList.h > (right): ...
4 years ago (2016-12-07 08:01:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2558643004/20001
4 years ago (2016-12-07 08:01:56 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-07 09:49:45 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-07 09:51:14 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3a0ebdbbfbde6acd2782c30671d42292740762f7
Cr-Commit-Position: refs/heads/master@{#436901}

Powered by Google App Engine
This is Rietveld 408576698