third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.h - Issue 2558643003: [InputEvent] Move 'beforeinput' logic into |CompositeEditCommand::willApplyEditing()| (3/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.h

Issue 2558643003: [InputEvent] Move 'beforeinput' logic into |CompositeEditCommand::willApplyEditing()| (3/3) (Closed)

Patch Set: yosin's review, fix nits Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/InputMethodController.cpp ('K') | « third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.h

diff --git a/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.h b/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.h

index 38fde66e32b7bcd58c4e80e2fcf4795095dd2576..12254abad1fce0e6f334d8c45f71941f81ebcf16 100644

--- a/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.h

+++ b/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.h

@@ -58,6 +58,9 @@ class CORE_EXPORT ReplaceSelectionCommand final : public CompositeEditCommand {

EphemeralRange insertedRange() const;

+ String textDataForInputEvent() const final;

+ DataTransfer* dataTransferForInputEvent() const final;

DECLARE_VIRTUAL_TRACE();

private:

@@ -67,7 +70,7 @@ class CORE_EXPORT ReplaceSelectionCommand final : public CompositeEditCommand {

InputEvent::InputType);

void doApply(EditingState*) override;

- InputEvent::InputType inputType() const override;

+ InputEvent::InputType inputType() const final;

bool isReplaceSelectionCommand() const override;

class InsertedNodes {