third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h - Issue 2558643003: [InputEvent] Move 'beforeinput' logic into |CompositeEditCommand::willApplyEditing()| (3/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h

Issue 2558643003: [InputEvent] Move 'beforeinput' logic into |CompositeEditCommand::willApplyEditing()| (3/3) (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp ('k') | third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp » ('j') | third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h

diff --git a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h

index 2289ba003dbe6ab03853a66d221e545f53d649ea..ab3954b3959cdd694e13e606a214cbdd85227c3e 100644

--- a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h

+++ b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h

@@ -116,6 +116,9 @@ class CORE_EXPORT CompositeEditCommand : public EditCommand {

protected:

explicit CompositeEditCommand(Document&);

+ // Returns |false| to abort applying command.

yosin_UTC9 2016/12/07 07:51:27 Is "cancel" better than "abort"? Should we mention

chongz 2016/12/07 15:22:21 Done.

+ virtual bool willApply();

// sugary-sweet convenience functions to help create and apply edit commands

// in composite commands