third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.h - Issue 2558643003: [InputEvent] Move 'beforeinput' logic into |CompositeEditCommand::willApplyEditing()| (3/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.h

Issue 2558643003: [InputEvent] Move 'beforeinput' logic into |CompositeEditCommand::willApplyEditing()| (3/3) (Closed)

Patch Set: xiaocheng's review 3: Rebase and remove updateStyleAndLayoutIgnorePendingStylesheets() Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.h

diff --git a/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.h b/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.h

index 38fde66e32b7bcd58c4e80e2fcf4795095dd2576..749ef2f3ceba962915149c57f60cf27b478cabc7 100644

--- a/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.h

+++ b/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.h

@@ -67,7 +67,6 @@ class CORE_EXPORT ReplaceSelectionCommand final : public CompositeEditCommand {

InputEvent::InputType);

void doApply(EditingState*) override;

- InputEvent::InputType inputType() const override;

bool isReplaceSelectionCommand() const override;

class InsertedNodes {

@@ -138,6 +137,10 @@ class CORE_EXPORT ReplaceSelectionCommand final : public CompositeEditCommand {

bool performTrivialReplace(const ReplacementFragment&, EditingState*);

+ InputEvent::InputType inputType() const final;

+ String textDataForInputEvent() const final;

+ DataTransfer* dataTransferForInputEvent() const final;

Position m_startOfInsertedContent;

Position m_endOfInsertedContent;

Member<EditingStyle> m_insertionStyle;