Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Unified Diff: third_party/WebKit/Source/core/editing/commands/EditCommand.h

Issue 2558643003: [InputEvent] Move 'beforeinput' logic into |CompositeEditCommand::willApplyEditing()| (3/3) (Closed)
Patch Set: xiaocheng's review 3: Rebase and remove updateStyleAndLayoutIgnorePendingStylesheets() Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/commands/EditCommand.h
diff --git a/third_party/WebKit/Source/core/editing/commands/EditCommand.h b/third_party/WebKit/Source/core/editing/commands/EditCommand.h
index 34939bc1a28b5aa947b02f3d3c7cb689dd5e0aba..51b550e6953f5914d8a8a51d7ec5311048652179 100644
--- a/third_party/WebKit/Source/core/editing/commands/EditCommand.h
+++ b/third_party/WebKit/Source/core/editing/commands/EditCommand.h
@@ -28,7 +28,6 @@
#include "core/CoreExport.h"
#include "core/editing/VisibleSelection.h"
-#include "core/events/InputEvent.h"
#include "platform/heap/Handle.h"
namespace blink {
@@ -43,8 +42,6 @@ class CORE_EXPORT EditCommand : public GarbageCollectedFinalized<EditCommand> {
void setParent(CompositeEditCommand*);
- virtual InputEvent::InputType inputType() const;
-
const VisibleSelection& startingSelection() const {
return m_startingSelection;
}
@@ -57,9 +54,6 @@ class CORE_EXPORT EditCommand : public GarbageCollectedFinalized<EditCommand> {
// The |EditingState*| argument must not be nullptr.
virtual void doApply(EditingState*) = 0;
- // |TypingCommand| will return the text of the last |m_commands|.
- virtual String textDataForInputEvent() const;
-
DECLARE_VIRTUAL_TRACE();
protected:

Powered by Google App Engine
This is Rietveld 408576698