Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: third_party/WebKit/Source/core/editing/EditingUtilities.h

Issue 2558643003: [InputEvent] Move 'beforeinput' logic into |CompositeEditCommand::willApplyEditing()| (3/3) (Closed)
Patch Set: xiaocheng's review 3: Rebase and remove updateStyleAndLayoutIgnorePendingStylesheets() Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/EditingUtilities.h
diff --git a/third_party/WebKit/Source/core/editing/EditingUtilities.h b/third_party/WebKit/Source/core/editing/EditingUtilities.h
index 0b334ec53ffe6695c93391388a89bec3ff590747..0337d9cd20f077f1005feca1d647b0639f4f1f81 100644
--- a/third_party/WebKit/Source/core/editing/EditingUtilities.h
+++ b/third_party/WebKit/Source/core/editing/EditingUtilities.h
@@ -58,6 +58,8 @@ enum class DeleteDirection {
Backward,
};
+enum class EditCommandSource;
+class CompositeEditCommand;
class Document;
class Element;
class HTMLElement;
@@ -411,28 +413,33 @@ String stringWithRebalancedWhitespace(const String&,
const String& nonBreakingSpaceString();
// -------------------------------------------------------------------------
-// Events
+// InputEvent
// -------------------------------------------------------------------------
-// Functions dispatch InputEvent
-DispatchEventResult dispatchBeforeInputInsertText(EventTarget*,
- const String& data);
-DispatchEventResult dispatchBeforeInputFromComposition(
- EventTarget*,
- InputEvent::InputType,
- const String& data,
- InputEvent::EventCancelable);
-DispatchEventResult dispatchBeforeInputEditorCommand(EventTarget*,
- InputEvent::InputType,
- const RangeVector*);
-DispatchEventResult dispatchBeforeInputDataTransfer(EventTarget*,
- InputEvent::InputType,
- DataTransfer*,
- const RangeVector*);
-
InputEvent::InputType deletionInputTypeFromTextGranularity(DeleteDirection,
TextGranularity);
+// TODO(chongz): Move |isComposingFromCommand()| and |isCancelableFromCommand|
+// to 'CompositeEditCommand.cpp' after we've moved |Editor::appliedEditing()| to
+// |CompositeEditCommand::appliedEditing()|.
+// https://crbug.com/676001
+InputEvent::EventIsComposing isComposingFromCommand(
+ const CompositeEditCommand*);
+InputEvent::EventCancelable isCancelableFromCommand(
+ const CompositeEditCommand*);
+
+// TODO(chongz): Move |dispatchBeforeInputEvent()| to 'CompositeEditCommand.cpp'
+// after we've resolved the ordering issue WRT 'compositionupdate'.
+// https://crbug.com/675820
+bool dispatchBeforeInputEvent(EditCommandSource,
+ LocalFrame*,
+ Node* target,
+ InputEvent::InputType,
+ const String& data,
+ DataTransfer*,
+ InputEvent::EventCancelable,
+ InputEvent::EventIsComposing,
+ const RangeVector*);
} // namespace blink
#endif
« no previous file with comments | « third_party/WebKit/Source/core/clipboard/DataTransfer.cpp ('k') | third_party/WebKit/Source/core/editing/EditingUtilities.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698