third_party/WebKit/LayoutTests/fast/events/inputevents/inputevent-keyboard.html - Issue 2558643003: [InputEvent] Move 'beforeinput' logic into |CompositeEditCommand::willApplyEditing()| (3/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/events/inputevents/inputevent-keyboard.html

Issue 2558643003: [InputEvent] Move 'beforeinput' logic into |CompositeEditCommand::willApplyEditing()| (3/3) (Closed)

Patch Set: xiaocheng's review 3: Rebase and remove updateStyleAndLayoutIgnorePendingStylesheets() Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/events/inputevents/inputevent-execcommand.html ('k') | third_party/WebKit/Source/core/clipboard/DataObject.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/events/inputevents/inputevent-keyboard.html

diff --git a/third_party/WebKit/LayoutTests/fast/events/inputevents/inputevent-keyboard.html b/third_party/WebKit/LayoutTests/fast/events/inputevents/inputevent-keyboard.html

index 0b58787862f9e4a9d6d12928a3dca062c14dee79..019cf67ff37e02ba74f20274adcc77dfc39636d7 100644

--- a/third_party/WebKit/LayoutTests/fast/events/inputevents/inputevent-keyboard.html

+++ b/third_party/WebKit/LayoutTests/fast/events/inputevents/inputevent-keyboard.html

@@ -33,7 +33,7 @@ test(function() {

lastBeforeInputType = NO_INPUT_EVENT_FIRED;

lastInputType = NO_INPUT_EVENT_FIRED;

eventSender.keyDown(key, modifiers);

- assert_equals(lastBeforeInputType, beforeInputType, `${modifiers.toString()}+${key} should produce beforeInputType: ${inputType}`);

+ assert_equals(lastBeforeInputType, beforeInputType, `${modifiers.toString()}+${key} should produce beforeInputType: ${beforeInputType}`);

assert_equals(lastInputType, inputType, `${modifiers.toString()}+${key} should produce inputType: ${inputType}`);

}

@@ -46,8 +46,8 @@ test(function() {

// Enter key has different behavior on <input>, <textarea> and ContentEditable.

document.getElementById('input').focus();

- testKeyDownInputType('Enter', [], 'insertLineBreak', NO_INPUT_EVENT_FIRED);

- testKeyDownInputType('Enter', ['shiftKey'], 'insertLineBreak', NO_INPUT_EVENT_FIRED);

+ testKeyDownInputType('Enter', [], NO_INPUT_EVENT_FIRED, NO_INPUT_EVENT_FIRED);

+ testKeyDownInputType('Enter', ['shiftKey'], NO_INPUT_EVENT_FIRED, NO_INPUT_EVENT_FIRED);

document.getElementById('textarea').focus();

testKeyDownInputType('Enter', [], 'insertLineBreak', 'insertLineBreak');