Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: third_party/WebKit/Source/core/editing/commands/TypingCommand.h

Issue 2558643003: [InputEvent] Move 'beforeinput' logic into |CompositeEditCommand::willApplyEditing()| (3/3) (Closed)
Patch Set: xiaocheng's review: Isolate |UndoStep| code; Move attribuates to private Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/commands/TypingCommand.h
diff --git a/third_party/WebKit/Source/core/editing/commands/TypingCommand.h b/third_party/WebKit/Source/core/editing/commands/TypingCommand.h
index ecc6a3df2097432c17d46c927a6ed7a77490a758..a739993efbaa32e708bddd5b7f5324d560651f15 100644
--- a/third_party/WebKit/Source/core/editing/commands/TypingCommand.h
+++ b/third_party/WebKit/Source/core/editing/commands/TypingCommand.h
@@ -107,8 +107,6 @@ class CORE_EXPORT TypingCommand final : public CompositeEditCommand {
ETypingCommand commandTypeOfOpenCommand() const { return m_commandType; }
TextCompositionType compositionType() const { return m_compositionType; }
- // Returns text data of the last added typing.
- String textDataForInputEvent() const final;
private:
static TypingCommand* create(
@@ -144,7 +142,6 @@ class CORE_EXPORT TypingCommand final : public CompositeEditCommand {
static TypingCommand* lastTypingCommandIfStillOpenForTyping(LocalFrame*);
void doApply(EditingState*) override;
- InputEvent::InputType inputType() const override;
bool isTypingCommand() const override;
bool preservesTypingStyle() const override { return m_preservesTypingStyle; }
void setShouldRetainAutocorrectionIndicator(bool retain) override {
@@ -172,6 +169,11 @@ class CORE_EXPORT TypingCommand final : public CompositeEditCommand {
bool isIncrementalInsertion() const { return m_isIncrementalInsertion; }
+ InputEvent::InputType inputType() const final;
+ // Returns text data of the last added typing.
+ String textDataForInputEvent() const final;
+ RangeVector* targetRangesForInputEvent() const final;
+
ETypingCommand m_commandType;
String m_textToInsert;
InputEvent::InputType m_inputType;

Powered by Google App Engine
This is Rietveld 408576698