[InputEvent] Move 'beforeinput' logic into |CompositeEditCommand::willApplyEditing()| (3/3)

third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

Index: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
diff --git a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
index 866d02dfe99734e203c106c3f9c8b144b4f294f3..22edeafd43f2e2f52206c854da66af5d96a88573 100644
--- a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
+++ b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
@@ -56,6 +56,7 @@
 #include "core/editing/commands/SplitElementCommand.h"
 #include "core/editing/commands/SplitTextNodeCommand.h"
 #include "core/editing/commands/SplitTextNodeContainingElementCommand.h"
+#include "core/editing/commands/TypingCommand.h"
 #include "core/editing/commands/WrapContentsInDummySpanCommand.h"
 #include "core/editing/iterators/TextIterator.h"
 #include "core/editing/markers/DocumentMarkerController.h"
@@ -149,14 +150,18 @@ void EditCommandComposition::reapply(EditCommandSource source) {
   frame->editor().reappliedEditing(this);
 }
 
-bool EditCommandComposition::willUnapply(EditCommandSource) {
-  // TODO(chongz): Fire 'beforeinput' for 'historyUndo'.
-  return true;
+bool EditCommandComposition::willUnapply(EditCommandSource source) {
+  return dispatchBeforeInputEvent(source, m_document->frame(), m_document,

[chongz, 2016/12/20 23:27:52]

Added to cover undo command from "EditorCommand.cpp::Command::execute()".
Also fixes https://crbug.com/652436 - We should fire undo/redo on |document|.

+                                  InputEvent::InputType::HistoryUndo, nullAtom,
+                                  nullptr, InputEvent::IsCancelable,
+                                  InputEvent::NotComposing, nullptr);
 }
 
-bool EditCommandComposition::willReapply(EditCommandSource) {
-  // TODO(chongz): Fire 'beforeinput' for 'historyRedo'.
-  return true;
+bool EditCommandComposition::willReapply(EditCommandSource source) {
+  return dispatchBeforeInputEvent(source, m_document->frame(), m_document,

[chongz, 2016/12/20 23:27:52]

Added to cover redo command from "EditorCommand.cpp::Command::execute()".
Also fixes https://crbug.com/652436 - We should fire undo/redo on |document|.

+                                  InputEvent::InputType::HistoryRedo, nullAtom,
+                                  nullptr, InputEvent::IsCancelable,
+                                  InputEvent::NotComposing, nullptr);
 }
 
 void EditCommandComposition::append(SimpleEditCommand* command) {
@@ -225,6 +230,11 @@ bool CompositeEditCommand::apply(EditCommandSource source) {
   }
   ensureComposition();
 
+  // Covers the initial TypingCommand and other top-level commands.
+  // TypingCommand::willAddTypingToOpenCommand() also calls willApplyEditing().
+  if (!willApplyEditing(source))
+    return false;
+
   // Changes to the document may have been made since the last editing operation
   // that require a layout, as in <rdar://problem/5658603>. Low level
   // operations, like RemoveNodeCommand, don't require a layout because the high
@@ -232,9 +242,6 @@ bool CompositeEditCommand::apply(EditCommandSource source) {
   // the creation of VisiblePositions).
   document().updateStyleAndLayoutIgnorePendingStylesheets();
 
-  if (!willApplyEditing(source))
-    return false;
-
   LocalFrame* frame = document().frame();
   DCHECK(frame);
   EditingState editingState;
@@ -262,9 +269,38 @@ EditCommandComposition* CompositeEditCommand::ensureComposition() {
   return command->m_composition.get();
 }
 
-bool CompositeEditCommand::willApplyEditing(EditCommandSource) {
-  // TODO(chongz): Move all the 'beforeinput' dispatching logic here.
-  return true;
+bool CompositeEditCommand::willApplyEditing(EditCommandSource source) {
+  // TODO(chongz): Remove the following code after we have ensured it's OK to
+  // fire 'beforeinput' after 'compositionupdate'.
+  // https://crbug.com/675820
+  if (isTypingCommand() && (toTypingCommand(this)->compositionType() ==
+                                TypingCommand::TextCompositionUpdate ||
+                            toTypingCommand(this)->compositionType() ==
+                                TypingCommand::TextCompositionConfirm))
+    return true;
+  return dispatchBeforeInputEvent(

[chongz, 2016/12/20 23:27:52]

Covers all hot keys, context menu, cut&paste, drag&drop, spell checker and the
first text editing action from typing or IME.

+      source, document().frame(), eventTargetNodeForDocument(&document()),
+      inputType(), textDataForInputEvent(), dataTransferForInputEvent(),
+      isCancelableFromCommand(this), isComposingFromCommand(this),
+      targetRangesForInputEvent());
+}
+
+InputEvent::InputType CompositeEditCommand::inputType() const {
+  return InputEvent::InputType::None;
+}
+
+String CompositeEditCommand::textDataForInputEvent() const {
+  return nullAtom;
+}
+
+DataTransfer* CompositeEditCommand::dataTransferForInputEvent() const {
+  return nullptr;
+}
+
+RangeVector* CompositeEditCommand::targetRangesForInputEvent() const {
+  if (!document().frame()->editor().canEditRichly())
+    return nullptr;
+  return new RangeVector(1, document().frame()->selection().firstRange());

[chongz, 2016/12/20 23:27:52]

New implementation, also fixes https://crbug.com/652429 - We should always
return current selection for ContentEditable if no better choice.

[Xiaocheng, 2016/12/21 02:56:39]

What are the ranges used by the current implementation?

Is it possible to somehow separate refactoring with behavior changes?

[chongz, 2016/12/21 23:59:24]

Reverted and will fix in another patch. 

We used to return |nullptr| for types other than |TypingCommand::delete*| and
|InputType::InsertReplacementText|.

 }
 
 bool CompositeEditCommand::preservesTypingStyle() const {