third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp - Issue 2558643003: [InputEvent] Move 'beforeinput' logic into |CompositeEditCommand::willApplyEditing()| (3/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp

Issue 2558643003: [InputEvent] Move 'beforeinput' logic into |CompositeEditCommand::willApplyEditing()| (3/3) (Closed)

Patch Set: xiaocheng's review: Isolate |UndoStep| code; Move attribuates to private Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp

diff --git a/third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp b/third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp

index 761d9a136a7b0f8ce6a0b2203d0fd7ecb3f42460..8b73a0dfa4034ed60d732eea6db64b1242d197e5 100644

--- a/third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp

+++ b/third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp

@@ -60,11 +60,6 @@ bool Editor::handleEditingKeyboardEvent(KeyboardEvent* evt) {

if (!behavior().shouldInsertCharacter(*evt) || !canEdit())

return false;

- // Return true to prevent default action. e.g. Space key scroll.

- if (dispatchBeforeInputInsertText(evt->target(), keyEvent->text) !=

chongz 2016/12/20 23:27:52 Removed, typing was covered by |TypingCommand => w

- DispatchEventResult::NotCanceled)

- return true;

return insertText(keyEvent->text, evt);

}