third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp - Issue 2558643003: [InputEvent] Move 'beforeinput' logic into |CompositeEditCommand::willApplyEditing()| (3/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

Issue 2558643003: [InputEvent] Move 'beforeinput' logic into |CompositeEditCommand::willApplyEditing()| (3/3) (Closed)

Patch Set: Rebase on EditCommandSource and willApply() CLs Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/Editor.cpp ('K') | « third_party/WebKit/Source/core/editing/InputMethodController.cpp ('k') | third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h » ('j') | third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp b/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

index d3e75f53cfb9b944f6abb23d6cf3d14b33c7f226..157bdf95f630d2f4570bfbdee4e8a859fe063d0e 100644

--- a/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

+++ b/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

@@ -990,7 +990,7 @@ TEST_F(InputMethodControllerTest, CompositionInputEventForDelete) {

// Delete the existing composition.

document().setTitle(emptyString());

controller().setComposition("", underlines, 0, 0);

- EXPECT_STREQ("beforeinput.data:;compositionend.data:;",

+ EXPECT_STREQ("beforeinput.data:null;input.data:null;compositionend.data:;",

document().title().utf8().data());

}