[InputEvent] Move 'beforeinput' logic into |CompositeEditCommand::willApplyEditing()| (3/3)

third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

 /*
  * Copyright (C) 2005, 2006, 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2009, 2010, 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 2108 matching lines @@
 }
 
 bool ReplaceSelectionCommand::isReplaceSelectionCommand() const {
   return true;
 }
 
 EphemeralRange ReplaceSelectionCommand::insertedRange() const {
   return EphemeralRange(m_startOfInsertedRange, m_endOfInsertedRange);
 }
 
+String ReplaceSelectionCommand::textDataForInputEvent() const {
+  return m_documentFragment->textContent();

[chongz, 2016/12/20 23:27:53]

New implementation.

[Xiaocheng, 2016/12/21 02:56:39]

What text data does the current implementation use when firing bebeforeinput for
ReplaceSelectionCommand?

[chongz, 2016/12/21 23:59:24]

Sorry for the confusion, this is actually the current behavior, but I just
summarized the implementation from
"EditingUtilities.cpp::dispatchBeforeInputDataTransfer()". 

Since the callers to |dispatchBeforeInputDataTransfer()| could only be paste,
drop and spellchecker, and they both use |ReplaceSelectionCommand|, I think it
makes more sense to have the logic here.

+}
+
+DataTransfer* ReplaceSelectionCommand::dataTransferForInputEvent() const {
+  switch (m_inputType) {
+    case InputEvent::InputType::InsertFromPaste:
+    case InputEvent::InputType::InsertFromDrop:
+    case InputEvent::InputType::InsertReplacementText:
+      return DataTransfer::createForInputEvent(
+          textDataForInputEvent(), createMarkup(m_documentFragment));

[chongz, 2016/12/20 23:27:53]

New implementation.

[Xiaocheng, 2016/12/21 02:56:39]

Similar question as above.

[chongz, 2016/12/21 23:59:24]

Similar answer as above.

+    default:
+      return CompositeEditCommand::dataTransferForInputEvent();
+  }
+}
+
 DEFINE_TRACE(ReplaceSelectionCommand) {
   visitor->trace(m_startOfInsertedContent);
   visitor->trace(m_endOfInsertedContent);
   visitor->trace(m_insertionStyle);
   visitor->trace(m_documentFragment);
   visitor->trace(m_startOfInsertedRange);
   visitor->trace(m_endOfInsertedRange);
   CompositeEditCommand::trace(visitor);
 }
 
 }  // namespace blink