[InputEvent] Move 'beforeinput' logic into |CompositeEditCommand::willApplyEditing()| (3/3)

third_party/WebKit/Source/core/editing/EditingUtilities.h

 /*
  * Copyright (C) 2004, 2006, 2008 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 40 matching lines @@
   // Standard Annex #29, Unicode text segmentation[1].
   // [1] http://www.unicode.org/reports/tr29/
   GraphemeCluster,
 };
 
 enum class DeleteDirection {
   Forward,
   Backward,
 };
 
+enum class EditCommandSource;
+class CompositeEditCommand;
 class Document;
 class Element;
 class HTMLElement;
 class HTMLSpanElement;
 class Node;
 class Range;
 
 // This file contains a set of helper functions used by the editing commands
 
 CORE_EXPORT bool needsLayoutTreeUpdate(const Node&);
@@ skipping 333 matching lines @@
   return character == '\'' || character == rightSingleQuotationMarkCharacter ||
          character == hebrewPunctuationGershayimCharacter;
 }
 
 String stringWithRebalancedWhitespace(const String&,
                                       bool startIsStartOfParagraph,
                                       bool shouldEmitNBSPbeforeEnd);
 const String& nonBreakingSpaceString();
 
 // -------------------------------------------------------------------------
-// Events
+// InputEvent
 // -------------------------------------------------------------------------
 
-// Functions dispatch InputEvent
-DispatchEventResult dispatchBeforeInputInsertText(EventTarget*,
-                                                  const String& data);
-DispatchEventResult dispatchBeforeInputFromComposition(
-    EventTarget*,
-    InputEvent::InputType,
-    const String& data,
-    InputEvent::EventCancelable);
-DispatchEventResult dispatchBeforeInputEditorCommand(EventTarget*,
-                                                     InputEvent::InputType,
-                                                     const RangeVector*);
-DispatchEventResult dispatchBeforeInputDataTransfer(EventTarget*,
-                                                    InputEvent::InputType,
-                                                    DataTransfer*,
-                                                    const RangeVector*);

[chongz, 2016/12/20 23:27:51]

Combined into a single |dispatchBeforeInputEvent()| below.

-
 InputEvent::InputType deletionInputTypeFromTextGranularity(DeleteDirection,
                                                            TextGranularity);
 
+// TODO(chongz): Move |isComposingFromCommand()| and |isCancelableFromCommand|
+// to 'CompositeEditCommand.cpp' after we've moved |Editor::appliedEditing()| to
+// |CompositeEditCommand::appliedEditing()|.
+// https://crbug.com/676001
+InputEvent::EventIsComposing isComposingFromCommand(

[chongz, 2016/12/20 23:27:51]

Moved from |Editor.cpp::isComposingFromCommand()|.

+    const CompositeEditCommand*);
+InputEvent::EventCancelable isCancelableFromCommand(

[chongz, 2016/12/20 23:27:51]

New method.

+    const CompositeEditCommand*);
+
+// TODO(chongz): Move |dispatchBeforeInputEvent()| to 'CompositeEditCommand.cpp'
+// after we've resolved the ordering issue WRT 'compositionupdate'.
+// https://crbug.com/675820
+bool dispatchBeforeInputEvent(EditCommandSource,

[chongz, 2016/12/20 23:27:51]

Combined from 4x |dispatchBeforeInput*()| above.

+                              LocalFrame*,
+                              Node* target,
+                              InputEvent::InputType,
+                              const String& data,
+                              DataTransfer*,
+                              InputEvent::EventCancelable,
+                              InputEvent::EventIsComposing,
+                              const RangeVector*);
 }  // namespace blink
 
 #endif