third_party/WebKit/LayoutTests/fast/events/inputevents/inputevent-drag-drop.html - Issue 2558643003: [InputEvent] Move 'beforeinput' logic into |CompositeEditCommand::willApplyEditing()| (3/3)

Side by Side Diff: third_party/WebKit/LayoutTests/fast/events/inputevents/inputevent-drag-drop.html

Issue 2558643003: [InputEvent] Move 'beforeinput' logic into |CompositeEditCommand::willApplyEditing()| (3/3) (Closed)

Patch Set: Retain the order of firing 'beforeinput' before 'compositionupdate' Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/fast/events/inputevents/inputevent-compositionupdate.html ('K') | « third_party/WebKit/LayoutTests/fast/events/inputevents/inputevent-compositionupdate.html ('k') | third_party/WebKit/LayoutTests/fast/events/inputevents/inputevent-execcommand.html » ('j') | third_party/WebKit/Source/core/editing/EditingUtilities.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>InputEvent: beforeinput for Drag and Drop</title>	4 <title>InputEvent: beforeinput for Drag and Drop</title>

5 <script src="../../../resources/testharness.js"></script>	5 <script src="../../../resources/testharness.js"></script>

6 <script src="../../../resources/testharnessreport.js"></script>	6 <script src="../../../resources/testharnessreport.js"></script>

7 <style>	7 <style>

8 div {	8 div {

9 width: 100px;	9 width: 100px;

10 height: 100px;	10 height: 100px;

(...skipping 142 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
153 function testDragDropEventOrder(dragElement, dropElement, expectedOrder) {	153 function testDragDropEventOrder(dragElement, dropElement, expectedOrder) {

154 assert_equals(dragElement.children.length, 1);	154 assert_equals(dragElement.children.length, 1);

155 eventOrderRecorder = [];	155 eventOrderRecorder = [];

156 simulateDragDrop(dragElement, dropElement);	156 simulateDragDrop(dragElement, dropElement);

157 assert_array_equals(eventOrderRecorder, expectedOrder,	157 assert_array_equals(eventOrderRecorder, expectedOrder,

158 `Testing drag ${dragElement.id} onto ${dropElement.id} actual order: ${eventOrderRecorder}`);	158 `Testing drag ${dragElement.id} onto ${dropElement.id} actual order: ${eventOrderRecorder}`);

159 }	159 }

160	160

161 // Test Drag and Drop.	161 // Test Drag and Drop.

162 testDragDropEventOrder(editable1, editable2,	162 testDragDropEventOrder(editable1, editable2,

163 ['editable2:drop', 'beforeinput:boldtext:deleteByDrag', 'input:editable1 :deleteByDrag',	163 ['editable2:drop', 'beforeinput:editable1:deleteByDrag', 'input:editable 1:deleteByDrag',

164 'beforeinput:editable2:insertFromDrop', 'input:editable2:insertFromDrop' , 'editable1:dragend']);	164 'beforeinput:editable2:insertFromDrop', 'input:editable2:insertFromDrop' , 'editable1:dragend']);

165 testRunner.execCommand('undo');	165 testRunner.execCommand('undo');

166 }, 'Testing Drag and Drop event order');	166 }, 'Testing Drag and Drop event order');

167	167

168 test(function() {	168 test(function() {

169 assertCleanInitialDOM();	169 assertCleanInitialDOM();

170 assert_not_equals(window.eventSender, undefined, 'This test requires eventSe nder.');	170 assert_not_equals(window.eventSender, undefined, 'This test requires eventSe nder.');

171 assert_not_equals(window.testRunner, undefined, 'This test requires testRunn er.');	171 assert_not_equals(window.testRunner, undefined, 'This test requires testRunn er.');

172	172

173 const editable1 = document.getElementById('editable1');	173 const editable1 = document.getElementById('editable1');

(...skipping 120 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
294 testDragDropEventOrder(editable1, editable2,	294 testDragDropEventOrder(editable1, editable2,

295 ['editable2:drop', 'beforeinput:editable1:deleteByDrag', 'beforeinput:ed itable2:insertFromDrop',	295 ['editable2:drop', 'beforeinput:editable1:deleteByDrag', 'beforeinput:ed itable2:insertFromDrop',

296 'input:editable2:insertFromDrop', 'editable1:dragend']);	296 'input:editable2:insertFromDrop', 'editable1:dragend']);

297 editable1.removeEventListener('beforeinput', removeEditable1Listener);	297 editable1.removeEventListener('beforeinput', removeEditable1Listener);

298 testRunner.execCommand('undo');	298 testRunner.execCommand('undo');

299 document.body.appendChild(editable1);	299 document.body.appendChild(editable1);

300 }, 'Testing element removed by event handler');	300 }, 'Testing element removed by event handler');

301 </script>	301 </script>

302 </body>	302 </body>

303 </html>	303 </html>

OLD	NEW