Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2558633003:
Track intersection of HTMLMediaElement with root frame. (Closed)
|
Created:
4 years ago by szager1 Modified:
4 years ago CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, nessy, Srirama, vcarbune.chromium Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionTrack intersection of HTMLMediaElement with root frame.
This is the intersection of interest; previously, if a media element
was in an iframe, it would track its intersection with the iframe
boundary.
Note that the localFrameRoot() code is temporary; a follow-up patch
which refactors IntersectionGeometry will change this argument to
nullptr. I'm putting this one-line change in separate patch to isolate
the behavioral change.
R=xjz@chromium.org
BUG=643964
Committed: https://crrev.com/f57a6a8e8b77b55410f1c16340fcc1608298e4f4
Cr-Commit-Position: refs/heads/master@{#437319}
Patch Set 1 #
Dependent Patchsets: Messages
Total messages: 22 (10 generated)
LGTM Thanks!
The CQ bit was checked by szager@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== Track intersection of HTMLMediaElement with root frame. This is the intersection of interest; previously, if a media element was in an iframe, it would track its intersection with the iframe boundary. Note that the localFrameRoot() code is temporary; a follow-up patch which refactors IntersectionGeometry will change this argument to nullptr. I'm putting this one-line change in separate patch to isolate the behavioral change. R=xjz@chromium.org BUG= ========== to ========== Track intersection of HTMLMediaElement with root frame. This is the intersection of interest; previously, if a media element was in an iframe, it would track its intersection with the iframe boundary. Note that the localFrameRoot() code is temporary; a follow-up patch which refactors IntersectionGeometry will change this argument to nullptr. I'm putting this one-line change in separate patch to isolate the behavioral change. R=xjz@chromium.org BUG= ==========
szager@chromium.org changed reviewers: + mlamouri@chromium.org
+mlamouri for OWNERS
mlamouri@chromium.org changed reviewers: + zqzhang@chromium.org
+zqzhang@ to review because he reviewed the original CL
non-owner lgtm (actually it wasn't me who reviewed the original CL) mlamouri@, can you rubberstamp it? nit: Add a bug number?
Description was changed from ========== Track intersection of HTMLMediaElement with root frame. This is the intersection of interest; previously, if a media element was in an iframe, it would track its intersection with the iframe boundary. Note that the localFrameRoot() code is temporary; a follow-up patch which refactors IntersectionGeometry will change this argument to nullptr. I'm putting this one-line change in separate patch to isolate the behavioral change. R=xjz@chromium.org BUG= ========== to ========== Track intersection of HTMLMediaElement with root frame. This is the intersection of interest; previously, if a media element was in an iframe, it would track its intersection with the iframe boundary. Note that the localFrameRoot() code is temporary; a follow-up patch which refactors IntersectionGeometry will change this argument to nullptr. I'm putting this one-line change in separate patch to isolate the behavioral change. R=xjz@chromium.org BUG=643964 ==========
On 2016/12/07 15:40:03, Zhiqiang Zhang wrote: > non-owner lgtm (actually it wasn't me who reviewed the original CL) > mlamouri@, can you rubberstamp it? > > nit: Add a bug number? Done.
lgtm
The CQ bit was checked by szager@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481222840590080, "parent_rev":
"1e66117dec44b6e7dd155aabd5f85c9c1702b64e", "commit_rev":
"cd6132ec609f03397db2400647eec79a6a66a724"}
Message was sent while issue was closed.
Description was changed from ========== Track intersection of HTMLMediaElement with root frame. This is the intersection of interest; previously, if a media element was in an iframe, it would track its intersection with the iframe boundary. Note that the localFrameRoot() code is temporary; a follow-up patch which refactors IntersectionGeometry will change this argument to nullptr. I'm putting this one-line change in separate patch to isolate the behavioral change. R=xjz@chromium.org BUG=643964 ========== to ========== Track intersection of HTMLMediaElement with root frame. This is the intersection of interest; previously, if a media element was in an iframe, it would track its intersection with the iframe boundary. Note that the localFrameRoot() code is temporary; a follow-up patch which refactors IntersectionGeometry will change this argument to nullptr. I'm putting this one-line change in separate patch to isolate the behavioral change. R=xjz@chromium.org BUG=643964 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Track intersection of HTMLMediaElement with root frame. This is the intersection of interest; previously, if a media element was in an iframe, it would track its intersection with the iframe boundary. Note that the localFrameRoot() code is temporary; a follow-up patch which refactors IntersectionGeometry will change this argument to nullptr. I'm putting this one-line change in separate patch to isolate the behavioral change. R=xjz@chromium.org BUG=643964 ========== to ========== Track intersection of HTMLMediaElement with root frame. This is the intersection of interest; previously, if a media element was in an iframe, it would track its intersection with the iframe boundary. Note that the localFrameRoot() code is temporary; a follow-up patch which refactors IntersectionGeometry will change this argument to nullptr. I'm putting this one-line change in separate patch to isolate the behavioral change. R=xjz@chromium.org BUG=643964 Committed: https://crrev.com/f57a6a8e8b77b55410f1c16340fcc1608298e4f4 Cr-Commit-Position: refs/heads/master@{#437319} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/f57a6a8e8b77b55410f1c16340fcc1608298e4f4 Cr-Commit-Position: refs/heads/master@{#437319} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
