Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2558633002: Now also support FunctionDeclarations instead of just closures. (Closed)

Created:
4 years ago by Emily Fortuna
Modified:
4 years ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Now also support FunctionDeclarations instead of just closures. BUG=https://github.com/dart-lang/sdk/issues/27394 R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/0631ed9187ae35c09744df5665d0477e3f090288

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -8 lines) Patch
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 6 chunks +32 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Emily Fortuna
Tests running as we speak.
4 years ago (2016-12-06 22:36:43 UTC) #2
sra1
lgtm https://codereview.chromium.org/2558633002/diff/1/pkg/compiler/lib/src/ssa/builder_kernel.dart File pkg/compiler/lib/src/ssa/builder_kernel.dart (right): https://codereview.chromium.org/2558633002/diff/1/pkg/compiler/lib/src/ssa/builder_kernel.dart#newcode146 pkg/compiler/lib/src/ssa/builder_kernel.dart:146: buildFunctionNode(target); why not: buildFunctionNode(target.function); you have to do ...
4 years ago (2016-12-06 23:26:15 UTC) #3
Emily Fortuna
4 years ago (2016-12-07 01:32:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0631ed9187ae35c09744df5665d0477e3f090288 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698