Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2558623002:
Fix use-after-scope issue in audio_renderer_impl. (Closed)
DescriptionFix use-after-scope issue in audio_renderer_impl.
This is crashing audio renderer tests with ToT clang, starting with
r288563. ASan detects it with -fsanitize-address-use-after-scope,
which is not enabled by default in Chromium yet.
BUG=671663
TBR=chcunningham@chromium.org
NOTRY=true
Committed: https://crrev.com/3137420f8293e02079a27a8c8fd65dd105d1c459
Cr-Commit-Position: refs/heads/master@{#436800}
Patch Set 1 #Patch Set 2 : . #Messages
Total messages: 16 (8 generated)
Description was changed from ========== Fix use-after-scope issue in audio_renderer_impl. This is crashing audio renderer tests with ToT clang, starting with r288563. ASan detects it with -fsanitize-address-use-after-scope, which is not enabled by default in Chromium yet. BUG=671663 ========== to ========== Fix use-after-scope issue in audio_renderer_impl. This is crashing audio renderer tests with ToT clang, starting with r288563. ASan detects it with -fsanitize-address-use-after-scope, which is not enabled by default in Chromium yet. BUG=671663 TBR=chcunningham@chromium.org ==========
eugenis@chromium.org changed reviewers: + chcunningham@chromium.org, rnk@chromium.org, thakis@chromium.org
Description was changed from ========== Fix use-after-scope issue in audio_renderer_impl. This is crashing audio renderer tests with ToT clang, starting with r288563. ASan detects it with -fsanitize-address-use-after-scope, which is not enabled by default in Chromium yet. BUG=671663 TBR=chcunningham@chromium.org ========== to ========== Fix use-after-scope issue in audio_renderer_impl. This is crashing audio renderer tests with ToT clang, starting with r288563. ASan detects it with -fsanitize-address-use-after-scope, which is not enabled by default in Chromium yet. BUG=671663 TBR=chcunningham@chromium.org NOTRY=true ==========
dalecurtis@chromium.org changed reviewers: + dalecurtis@chromium.org
Is this a real bug or are you just masking it with this change? I don't see anything wrong with this code? GetOutputDeviceInfo returns a struct, OutputDeviceInfo.
err, just masking a clang issue.
On 2016/12/06 23:40:47, DaleCurtis wrote: > Is this a real bug or are you just masking it with this change? I don't see > anything wrong with this code? GetOutputDeviceInfo returns a struct, > OutputDeviceInfo. the scope of OutputDeviceInfo struct in the original code is just one line, and output_params() returns a reference into it.
lgtm OIC, OutputDeviceInfo is ephermal, so the const& references something gone.
The CQ bit was checked by eugenis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481067770557140,
"parent_rev": "8ce2d94d4c0e379a706af80088142ffe7fb78925", "commit_rev":
"c721fb01816689de345c5d36963bb2070e2e9928"}
Message was sent while issue was closed.
Description was changed from ========== Fix use-after-scope issue in audio_renderer_impl. This is crashing audio renderer tests with ToT clang, starting with r288563. ASan detects it with -fsanitize-address-use-after-scope, which is not enabled by default in Chromium yet. BUG=671663 TBR=chcunningham@chromium.org NOTRY=true ========== to ========== Fix use-after-scope issue in audio_renderer_impl. This is crashing audio renderer tests with ToT clang, starting with r288563. ASan detects it with -fsanitize-address-use-after-scope, which is not enabled by default in Chromium yet. BUG=671663 TBR=chcunningham@chromium.org NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix use-after-scope issue in audio_renderer_impl. This is crashing audio renderer tests with ToT clang, starting with r288563. ASan detects it with -fsanitize-address-use-after-scope, which is not enabled by default in Chromium yet. BUG=671663 TBR=chcunningham@chromium.org NOTRY=true ========== to ========== Fix use-after-scope issue in audio_renderer_impl. This is crashing audio renderer tests with ToT clang, starting with r288563. ASan detects it with -fsanitize-address-use-after-scope, which is not enabled by default in Chromium yet. BUG=671663 TBR=chcunningham@chromium.org NOTRY=true Committed: https://crrev.com/3137420f8293e02079a27a8c8fd65dd105d1c459 Cr-Commit-Position: refs/heads/master@{#436800} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/3137420f8293e02079a27a8c8fd65dd105d1c459 Cr-Commit-Position: refs/heads/master@{#436800} |
