Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2558613002: Changed the SafeJsonParser connection error message. (Closed)

Created:
4 years ago by Patrick Monette
Modified:
4 years ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changed the SafeJsonParser connection error message. The previous error message was too generic, making it harder to find the culprit for the "Json error". BUG=670625 Committed: https://crrev.com/887e54f79784fa655609c00f3f03940a043f39a8 Cr-Commit-Position: refs/heads/master@{#437037}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M components/safe_json/safe_json_parser_impl.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Patrick Monette
PTAL
4 years ago (2016-12-06 22:14:47 UTC) #3
Bernhard Bauer
lgtm
4 years ago (2016-12-07 15:39:10 UTC) #4
Patrick Monette
Thanks!
4 years ago (2016-12-07 18:47:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2558613002/1
4 years ago (2016-12-07 18:48:26 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 19:48:16 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-07 19:50:36 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/887e54f79784fa655609c00f3f03940a043f39a8
Cr-Commit-Position: refs/heads/master@{#437037}

Powered by Google App Engine
This is Rietveld 408576698