Revert "reland of Improve linearized pdf load/show time."

Revert "reland of Improve linearized pdf load/show time."

This Cl reverts the linearized loading Cl. In order to do so it also reverst:

 * "Fix crash in Print Preview on rotating the preview in 'Clockwise' direction.."
 * "[PDF Plugin] Increase read buffer size"

The reason for revert is due to breaking loading of dynamic XFA forms.

Committed: https://crrev.com/adf55f3f29505455a4a80f8a354386dad64093ca
Cr-Commit-Position: refs/heads/master@{#436938}

[dsinclair, 2016-12-06 21:01:49]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 21:03:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-12-06 21:25:02]

dsinclair@chromium.org changed reviewers:
+ art-snake@yandex-team.ru, raymes@chromium.org, thestig@chromium.org,
tsepez@chromium.org

[dsinclair, 2016-12-06 21:25:03]

PTAL.

I was unable to make the form code work so ended up doing the revert. The second
patch set is the changes I had to make in order to get the browser_test for PDF
redirects to pass (it was hanging as we weren't failing the document load.)

The PDF's I had issue with are from
https://www.idrsolutions.com/jpdfforms/xfa-html5-example-conversions/. The
documents are linearized XFA dynamic forms. When loaded from the site they would
fail with the current code. When loaded from disk they worked fine.

[commit-bot: I haz the power, 2016-12-06 22:14:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 22:14:26]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-12-06 22:43:55]

RS LGTM

[dsinclair, 2016-12-07 13:56:10]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-12-07 13:56:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 14:00:45]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481118970599190,
"parent_rev": "b507bd96507622846266c26e7fe9abcdcb8001a5", "commit_rev":
"1ead463c8286b6fb668a7bcd576ede2f05793a5b"}

[commit-bot: I haz the power, 2016-12-07 14:01:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-07 14:03:54]

Description was changed from

==========
Revert "reland of Improve linearized pdf load/show time."

This Cl reverts the linearized loading Cl. In order to do so it also reverst:

 * "Fix crash in Print Preview on rotating the preview in 'Clockwise'
direction.."
 * "[PDF Plugin] Increase read buffer size"

The reason for revert is due to breaking loading of dynamic XFA forms.
==========

to

==========
Revert "reland of Improve linearized pdf load/show time."

This Cl reverts the linearized loading Cl. In order to do so it also reverst:

 * "Fix crash in Print Preview on rotating the preview in 'Clockwise'
direction.."
 * "[PDF Plugin] Increase read buffer size"

The reason for revert is due to breaking loading of dynamic XFA forms.

Committed: https://crrev.com/adf55f3f29505455a4a80f8a354386dad64093ca
Cr-Commit-Position: refs/heads/master@{#436938}
==========

[commit-bot: I haz the power, 2016-12-07 14:03:54]

Patchset 2 (id:??) landed as
https://crrev.com/adf55f3f29505455a4a80f8a354386dad64093ca
Cr-Commit-Position: refs/heads/master@{#436938}

[snake, 2016-12-09 18:46:53]

On 2016/12/07 14:03:54, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/adf55f3f29505455a4a80f8a354386dad64093ca
> Cr-Commit-Position: refs/heads/master@{#436938}

What problem with new document_loader and XFA dynamic forms?

[dsinclair, 2016-12-12 14:11:53]

On 2016/12/09 18:46:53, snake wrote:
> On 2016/12/07 14:03:54, commit-bot: I haz the power wrote:
> > Patchset 2 (id:??) landed as
> > https://crrev.com/adf55f3f29505455a4a80f8a354386dad64093ca
> > Cr-Commit-Position: refs/heads/master@{#436938}
> 
> What problem with new document_loader and XFA dynamic forms?

The PDF's I had issue with are from
https://www.idrsolutions.com/jpdfforms/xfa-html5-example-conversions/. The
documents are linearized XFA dynamic forms. When loaded from the site they would
fail with the current code (the please use acrobat page would be shown, no
moving the mouse the renderer would crash).
When loaded from disk they worked fine.

[snake, 2016-12-12 14:28:50]

On 2016/12/12 14:11:53, dsinclair wrote:
> On 2016/12/09 18:46:53, snake wrote:
> > On 2016/12/07 14:03:54, commit-bot: I haz the power wrote:
> > > Patchset 2 (id:??) landed as
> > > https://crrev.com/adf55f3f29505455a4a80f8a354386dad64093ca
> > > Cr-Commit-Position: refs/heads/master@{#436938}
> > 
> > What problem with new document_loader and XFA dynamic forms?
> 
> The PDF's I had issue with are from
> https://www.idrsolutions.com/jpdfforms/xfa-html5-example-conversions/. The
> documents are linearized XFA dynamic forms. When loaded from the site they
would
> fail with the current code (the please use acrobat page would be shown, no
> moving the mouse the renderer would crash).
> When loaded from disk they worked fine.

I cannot reproduce this issue, with new loader:
https://drive.google.com/open?id=0BzWfMBOuik2QY0hUT2JqUDhzWm8
Should I enable XFA feature in build to reproduce it?

[chromium-reviews, 2016-12-12 14:35:05]

You have to have pdf_enable_xfa true in order to repro

Dan

On Mon, Dec 12, 2016, 09:28 <art-snake@yandex-team.ru> wrote:

> On 2016/12/12 14:11:53, dsinclair wrote:
> > On 2016/12/09 18:46:53, snake wrote:
> > > On 2016/12/07 14:03:54, commit-bot: I haz the power wrote:
> > > > Patchset 2 (id:??) landed as
> > > > https://crrev.com/adf55f3f29505455a4a80f8a354386dad64093ca
> > > > Cr-Commit-Position: refs/heads/master@{#436938}
> > >
> > > What problem with new document_loader and XFA dynamic forms?
> >
> > The PDF's I had issue with are from
> > https://www.idrsolutions.com/jpdfforms/xfa-html5-example-conversions/.
> The
> > documents are linearized XFA dynamic forms. When loaded from the site
> they
> would
> > fail with the current code (the please use acrobat page would be shown,
> no
> > moving the mouse the renderer would crash).
> > When loaded from disk they worked fine.
>
> I cannot reproduce this issue, with new loader:
> https://drive.google.com/open?id=0BzWfMBOuik2QY0hUT2JqUDhzWm8
> Should I enable XFA feature in build to reproduce it?
>
> https://codereview.chromium.org/2558573002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.