google_apis/gcm/monitoring/gcm_stats_recorder.h - Issue 2558553002: GCM: Add Android UMA, and UMA for deleted/collapsed messages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/monitoring/gcm_stats_recorder.h

Issue 2558553002: GCM: Add Android UMA, and UMA for deleted/collapsed messages (Closed)

Patch Set: UMA_HISTOGRAM_BOOLEAN("GCM.DataMessageReceived", true); Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: google_apis/gcm/monitoring/gcm_stats_recorder.h

diff --git a/google_apis/gcm/monitoring/gcm_stats_recorder.h b/google_apis/gcm/monitoring/gcm_stats_recorder.h

index aee9179d6ff3eaee399798d95efa6528cfe0e0ad..7cd45ebefd1963a0c956bf2d5d825964e954ded7 100644

--- a/google_apis/gcm/monitoring/gcm_stats_recorder.h

+++ b/google_apis/gcm/monitoring/gcm_stats_recorder.h

@@ -110,9 +110,9 @@ class GCM_EXPORT GCMStatsRecorder {

int retries_left) = 0;

// Records that a data message has been received. If this message is not

- // sent to a registered app, to_registered_app shoudl be false. If it

- // indicates that a message has been dropped on the server, is_message_dropped

- // should be true.

+ // sent to a registered app, to_registered_app should be false. If it

+ // indicates that one or more messages were dropped on the server,

+ // message_type should be DELETED_MESSAGES.

virtual void RecordDataMessageReceived(const std::string& app_id,

const std::string& from,

int message_byte_size,