Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: tools/dom/scripts/htmldartgenerator.py

Issue 25585002: Make OptionElement construtor arguments named optional parameters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/dom/scripts/generator.py ('k') | tools/dom/scripts/htmlrenamer.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/scripts/htmldartgenerator.py
diff --git a/tools/dom/scripts/htmldartgenerator.py b/tools/dom/scripts/htmldartgenerator.py
index 7b7ca8ea0613d8e6afd8edc495505b7f4c149241..97fa1ba62119185b92445456cf2715c292bcad10 100644
--- a/tools/dom/scripts/htmldartgenerator.py
+++ b/tools/dom/scripts/htmldartgenerator.py
@@ -11,9 +11,9 @@ from generator import AnalyzeOperation, ConstantOutputOrder, \
DartDomNameOfAttribute, FindMatchingAttribute, \
TypeOrNothing, ConvertToFuture, GetCallbackInfo
from copy import deepcopy
-from htmlrenamer import convert_to_future_members, keep_overloaded_members, \
- private_html_members, dom_private_html_members, renamed_html_members, renamed_overloads, \
- removed_html_members
+from htmlrenamer import convert_to_future_members, custom_html_constructors, \
+ keep_overloaded_members, private_html_members, dom_private_html_members, renamed_html_members, \
+ renamed_overloads, removed_html_members
import logging
import monitored
import sys
@@ -598,7 +598,8 @@ class HtmlDartGenerator(object):
if not self._members_emitter:
return
- if base_class != self.RootClassName():
+ if (base_class != self.RootClassName() and
+ self._interface.id not in custom_html_constructors):
self._members_emitter.Emit(
' // To suppress missing implicit constructor warnings.\n'
' factory $CLASSNAME._() { '
« no previous file with comments | « tools/dom/scripts/generator.py ('k') | tools/dom/scripts/htmlrenamer.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698