Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 2558483003: Reland of rotate frames correctly for back camera (Closed)

Created:
4 years ago by shenghao
Modified:
4 years ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, xjz+watch_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of ate frames correctly for back camera (patchset #1 id:1 of https://codereview.chromium.org/2554903002/ ) Reason for revert: try to reland https://codereview.chromium.org/2508803002/# Original issue's description: > Revert of Rotate frames correctly for back camera (patchset #17 id:320001 of https://codereview.chromium.org/2508803002/ ) > > Reason for revert: > Causes compile failures: > > https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29/builds/81371/steps/compile/logs/stdio > > Original issue's description: > > Rotate frames correctly for back camera > > > > In 90 and 270 degree tablet mode, back camera used to show upside-down > > frames. We need to rotate the frames correctly for back cameras. > > > > BUG=chrome-os-partner:56762 > > TEST=Verify that back camera shows correct preview in all rotations. > > > > Committed: https://crrev.com/fd4e73efe59269463f10743694597074ef2ceefb > > Cr-Commit-Position: refs/heads/master@{#436594} > > TBR=wuchengli@chromium.org,posciak@chromium.org,henryhsu@chromium.org,mcasas@chromium.org,kcwu@chromium.org,shenghao@google.com,phistuck@gmail.com,shenghao@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chrome-os-partner:56762 > > Committed: https://crrev.com/78ba7d636db7e127c8587977482639c387644e6f > Cr-Commit-Position: refs/heads/master@{#436598} TBR=wuchengli@chromium.org,posciak@chromium.org,henryhsu@chromium.org,mcasas@chromium.org,kcwu@chromium.org,shenghao@google.com,phistuck@gmail.com,hbos@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chrome-os-partner:56762 Committed: https://crrev.com/ec8cf0e66777785a7685629ffb045016e0f12d74 Cr-Commit-Position: refs/heads/master@{#437206}

Patch Set 1 #

Patch Set 2 : fix compiler error #

Patch Set 3 : fix compiler error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+373 lines, -6 lines) Patch
M media/capture/BUILD.gn View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
A media/capture/video/linux/camera_facing_chromeos.h View 1 2 1 chunk +82 lines, -0 lines 0 comments Download
A media/capture/video/linux/camera_facing_chromeos.cc View 1 chunk +185 lines, -0 lines 0 comments Download
A media/capture/video/linux/camera_facing_chromeos_unittest.cc View 1 chunk +41 lines, -0 lines 0 comments Download
M media/capture/video/linux/video_capture_device_chromeos.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M media/capture/video/linux/video_capture_device_chromeos.cc View 1 3 chunks +52 lines, -1 line 0 comments Download
M media/capture/video/linux/video_capture_device_linux.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M media/capture/video/linux/video_capture_device_linux.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
shenghao
Created Reland of ate frames correctly for back camera
4 years ago (2016-12-07 06:11:09 UTC) #1
mcasas
On 2016/12/07 06:11:09, shenghao wrote: > Created Reland of ate frames correctly for back camera ...
4 years ago (2016-12-07 06:42:52 UTC) #8
PhistucK
And if you can just somehow change the issue number to have a prepended chrome-os-partner:, ...
4 years ago (2016-12-07 06:57:51 UTC) #9
shenghao
On 2016/12/07 06:57:51, PhistucK wrote: > And if you can just somehow change the issue ...
4 years ago (2016-12-07 08:14:23 UTC) #10
PhistucK
On 2016/12/07 08:14:23, shenghao wrote: > On 2016/12/07 06:57:51, PhistucK wrote: > > And if ...
4 years ago (2016-12-07 08:17:02 UTC) #12
shenghao
On 2016/12/07 08:17:02, PhistucK wrote: > On 2016/12/07 08:14:23, shenghao wrote: > > On 2016/12/07 ...
4 years ago (2016-12-07 09:41:07 UTC) #13
shenghao
4 years ago (2016-12-07 09:41:18 UTC) #14
wuchengli
lgtm
4 years ago (2016-12-08 07:18:55 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2558483003/200001
4 years ago (2016-12-08 07:58:37 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:200001)
4 years ago (2016-12-08 07:59:46 UTC) #20
commit-bot: I haz the power
4 years ago (2016-12-08 08:02:13 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ec8cf0e66777785a7685629ffb045016e0f12d74
Cr-Commit-Position: refs/heads/master@{#437206}

Powered by Google App Engine
This is Rietveld 408576698