Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2558483002: views: convert ToolbarActionsBarBubble to Harmony (Closed)

Created:
4 years ago by Elly Fong-Jones
Modified:
4 years ago
Reviewers:
Devlin
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

views: convert ToolbarActionsBarBubble to Harmony BUG=671656 Committed: https://crrev.com/7d30f44b11887d895ce436b4e8c977b2ddbaec3f Cr-Commit-Position: refs/heads/master@{#436660}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.cc View 5 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Elly Fong-Jones
rdevlin.cronin: ptal? :)
4 years ago (2016-12-06 16:59:20 UTC) #3
Devlin
I think there should be an associated bug for this so we can track the ...
4 years ago (2016-12-06 17:01:15 UTC) #4
Elly Fong-Jones
done :)
4 years ago (2016-12-06 17:08:44 UTC) #6
Devlin
lgtm, thanks!
4 years ago (2016-12-06 17:52:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2558483002/1
4 years ago (2016-12-06 17:54:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 18:47:50 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-06 18:50:55 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d30f44b11887d895ce436b4e8c977b2ddbaec3f
Cr-Commit-Position: refs/heads/master@{#436660}

Powered by Google App Engine
This is Rietveld 408576698