Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Side by Side Diff: tools/perf/benchmarks/start_with_url.py

Issue 2558473002: Disable start_with_url.cold.startup_pages on Nexus 7v2 and Nexus 9 (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from core import perf_benchmark 5 from core import perf_benchmark
6 import page_sets 6 import page_sets
7 7
8 from telemetry import benchmark 8 from telemetry import benchmark
9 from telemetry.timeline import chrome_trace_category_filter 9 from telemetry.timeline import chrome_trace_category_filter
10 from telemetry.web_perf import timeline_based_measurement 10 from telemetry.web_perf import timeline_based_measurement
(...skipping 26 matching lines...) Expand all
37 """Measures time to start Chrome cold with startup URLs.""" 37 """Measures time to start Chrome cold with startup URLs."""
38 38
39 page_set = page_sets.StartupPagesPageSet 39 page_set = page_sets.StartupPagesPageSet
40 options = {'pageset_repeat': 5} 40 options = {'pageset_repeat': 5}
41 41
42 def SetExtraBrowserOptions(self, options): 42 def SetExtraBrowserOptions(self, options):
43 options.clear_sytem_cache_for_browser_and_profile_on_start = True 43 options.clear_sytem_cache_for_browser_and_profile_on_start = True
44 super(StartWithUrlColdTBM, self).SetExtraBrowserOptions(options) 44 super(StartWithUrlColdTBM, self).SetExtraBrowserOptions(options)
45 45
46 @classmethod 46 @classmethod
47 def ShouldDisable(cls, possible_browser): # http://crbug.com/667470
48 return (possible_browser.platform.GetDeviceTypeName() in
49 ['Nexus 7v2', 'Nexus 9'])
50
51 @classmethod
47 def Name(cls): 52 def Name(cls):
48 return 'start_with_url.cold.startup_pages' 53 return 'start_with_url.cold.startup_pages'
49 54
50 55
51 @benchmark.Enabled('has tabs') 56 @benchmark.Enabled('has tabs')
52 @benchmark.Enabled('android') 57 @benchmark.Enabled('android')
53 @benchmark.Disabled('android-reference') # crbug.com/588786 58 @benchmark.Disabled('android-reference') # crbug.com/588786
54 @benchmark.Disabled('chromeos', 'linux', 'mac', 'win') 59 @benchmark.Disabled('chromeos', 'linux', 'mac', 'win')
55 class StartWithUrlWarmTBM(_StartupPerfBenchmark): 60 class StartWithUrlWarmTBM(_StartupPerfBenchmark):
56 """Measures stimetime to start Chrome warm with startup URLs.""" 61 """Measures stimetime to start Chrome warm with startup URLs."""
57 62
58 page_set = page_sets.StartupPagesPageSet 63 page_set = page_sets.StartupPagesPageSet
59 options = {'pageset_repeat': 11} 64 options = {'pageset_repeat': 11}
60 65
61 @classmethod 66 @classmethod
62 def Name(cls): 67 def Name(cls):
63 return 'start_with_url.warm.startup_pages' 68 return 'start_with_url.warm.startup_pages'
64 69
65 @classmethod 70 @classmethod
66 def ValueCanBeAddedPredicate(cls, value, is_first_result): 71 def ValueCanBeAddedPredicate(cls, value, is_first_result):
67 del value # unused 72 del value # unused
68 # Ignores first results because the first invocation is actualy cold since 73 # Ignores first results because the first invocation is actualy cold since
69 # we are loading the profile for the first time. 74 # we are loading the profile for the first time.
70 return not is_first_result 75 return not is_first_result
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698