Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2558453005:
Allow calling FontCache::purge() at any timing (Closed)
|
Created:
4 years ago by bashi Modified:
4 years ago Reviewers:
drott CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Justin Novosad, Rik, f(malita), blink-reviews, danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis, tasak Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAllow calling FontCache::purge() at any timing
MemoryCoordinator calls purge() when it receives memory pressure
signals. Allow calling purge() at any timing because memory pressure
signals can be triggered at any timing.
BUG=671502
Committed: https://crrev.com/e17e2ebb5d24ba236e8fb3b0d2ecf5f542be03ad
Cr-Commit-Position: refs/heads/master@{#437387}
Patch Set 1 #
Messages
Total messages: 27 (14 generated)
bashi@chromium.org changed reviewers: + drott@chromium.org
PTAL
The CQ bit was checked by bashi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
This CL in itself LGTM. As we discussed in our 1:1, we do still need better data on what these purge call actually achieve in terms of freeing memory.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
On 2016/12/08 08:34:46, drott wrote: > This CL in itself LGTM. As we discussed in our 1:1, we do still need better data > on what these purge call actually achieve in terms of freeing memory. Yes. Agreed.
The CQ bit was checked by bashi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by bashi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
You will get the best dry cleaning service in Noida from http://laundrybucket.co.in/. In this situation it is difficult to manage the time for people. That is why we have started to make a help for each person by contacting them into doorstep.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by bashi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by bashi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481233721175650, "parent_rev":
"ce561f6d1bf4c7b822afce8c710de1916ee8edee", "commit_rev":
"7385d15acb76e158ab537eba70e56f4fa0dbbcb5"}
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Allow calling FontCache::purge() at any timing MemoryCoordinator calls purge() when it receives memory pressure signals. Allow calling purge() at any timing because memory pressure signals can be triggered at any timing. BUG=671502 ========== to ========== Allow calling FontCache::purge() at any timing MemoryCoordinator calls purge() when it receives memory pressure signals. Allow calling purge() at any timing because memory pressure signals can be triggered at any timing. BUG=671502 Committed: https://crrev.com/e17e2ebb5d24ba236e8fb3b0d2ecf5f542be03ad Cr-Commit-Position: refs/heads/master@{#437387} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/e17e2ebb5d24ba236e8fb3b0d2ecf5f542be03ad Cr-Commit-Position: refs/heads/master@{#437387} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
