sdk/lib/_internal/compiler/implementation/js/builder.dart - Issue 255843005: Avoid generating VariableUse nodes with non-identifier names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js/builder.dart

Issue 255843005: Avoid generating VariableUse nodes with non-identifier names (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/compiler/implementation/js/builder.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js/builder.dart b/sdk/lib/_internal/compiler/implementation/js/builder.dart

index 6f6025e770c8bd2c2c6d4a472097252f2ee773ab..ea316a7fa57f4e93cca44f515dc1f7cead653c77 100644

--- a/sdk/lib/_internal/compiler/implementation/js/builder.dart

+++ b/sdk/lib/_internal/compiler/implementation/js/builder.dart

@@ -679,7 +679,7 @@ class MiniJsParser {

expectCategory(RSQUARE);

}

return new ArrayInitializer(values.length, values);

- } else if (last.startsWith("/")) {

+ } else if (last != null && last.startsWith("/")) {

String regexp = getDelimited(lastPosition);

getToken();

String flags = lastToken;

« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/js/nodes.dart » ('j') | no next file with comments »