Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: chrome/browser/favicon/favicon_handler.h

Issue 255843002: Renamed FaviconHandlerDelegate to FaviconDriver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/favicon/favicon_handler.h
diff --git a/chrome/browser/favicon/favicon_handler.h b/chrome/browser/favicon/favicon_handler.h
index a9e1826210df574a9a013aa8e2be50ebfa680456..4a2667ce5a32b96aad61b1047898f2b87851f29f 100644
--- a/chrome/browser/favicon/favicon_handler.h
+++ b/chrome/browser/favicon/favicon_handler.h
@@ -21,7 +21,7 @@
#include "url/gurl.h"
class FaviconClient;
-class FaviconHandlerDelegate;
+class FaviconDriver;
class SkBitmap;
namespace base {
@@ -87,7 +87,7 @@ class FaviconHandler {
};
FaviconHandler(FaviconClient* client,
- FaviconHandlerDelegate* delegate,
+ FaviconDriver* delegate,
blundell 2014/04/28 08:59:28 delegate should be changed to driver everywhere.
jif 2014/04/28 10:07:20 Done. "git grep -i delegate components/favicon" no
Type icon_type,
bool download_largest_icon);
virtual ~FaviconHandler();
@@ -295,8 +295,8 @@ class FaviconHandler {
// The client which implements embedder-specific Favicon operations.
FaviconClient* client_; // weak
- // This handler's delegate.
- FaviconHandlerDelegate* delegate_; // weak
+ // This handler's driver.
+ FaviconDriver* delegate_; // weak
// Best image we've seen so far. As images are downloaded from the page they
// are stored here. When there is an exact match, or no more images are
« no previous file with comments | « no previous file | chrome/browser/favicon/favicon_handler.cc » ('j') | chrome/browser/favicon/favicon_handler_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698