Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Issue 2558373002: Remove last usage of CFX_ObjectArray. (Closed)

Created:
4 years ago by Tom Sepez
Modified:
4 years ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : unqiue_ptr to avoid copies #

Patch Set 3 : disallow copy and assign #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -120 lines) Patch
M core/fpdfapi/parser/cpdf_stream_acc.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M core/fxcrt/fx_basic.h View 1 chunk +0 lines, -102 lines 0 comments Download
M xfa/fxfa/app/xfa_ffapp.cpp View 1 3 chunks +16 lines, -18 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Tom Sepez
Dan, ready for review.
4 years ago (2016-12-08 19:06:47 UTC) #4
Tom Sepez
On 2016/12/08 19:06:47, Tom Sepez wrote: > Dan, ready for review. Mkay, try 2.
4 years ago (2016-12-08 20:00:19 UTC) #9
dsinclair
lgtm
4 years ago (2016-12-08 20:05:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2558373002/40001
4 years ago (2016-12-08 20:16:29 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-08 20:28:10 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/80c40de632cc089979dfd5bea351f58aa209...

Powered by Google App Engine
This is Rietveld 408576698