Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1225)

Unified Diff: components/arc/arc_bridge_service_impl.cc

Issue 2558313002: Remove explicit singletonness of ArcBridgeService part 5. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/arc/arc_bridge_service_impl.cc
diff --git a/components/arc/arc_bridge_service_impl.cc b/components/arc/arc_bridge_service_impl.cc
index 51a7cd7f6864cf7f5f0b6b3a0563a7bef348a43d..f3efcade5a8dd8085e5de235526317df0bf01deb 100644
--- a/components/arc/arc_bridge_service_impl.cc
+++ b/components/arc/arc_bridge_service_impl.cc
@@ -21,9 +21,6 @@
#include "components/prefs/pref_service.h"
namespace arc {
-
-extern ArcBridgeService* g_arc_bridge_service;
-
namespace {
constexpr int64_t kReconnectDelayInSeconds = 5;
hidehiko 2016/12/08 15:43:17 FYI/Off-topic: soon, I'll work on refactoring reco
Luis Héctor Chávez 2016/12/08 17:38:25 sgtm, I wrote this before I realized base::TimeDel
} // namespace
@@ -32,17 +29,11 @@ ArcBridgeServiceImpl::ArcBridgeServiceImpl(
const scoped_refptr<base::TaskRunner>& blocking_task_runner)
: session_started_(false),
factory_(base::Bind(ArcSession::Create, this, blocking_task_runner)),
- weak_factory_(this) {
- DCHECK(!g_arc_bridge_service);
- g_arc_bridge_service = this;
-}
+ weak_factory_(this) {}
ArcBridgeServiceImpl::~ArcBridgeServiceImpl() {
if (arc_session_)
arc_session_->RemoveObserver(this);
-
- DCHECK(g_arc_bridge_service == this);
- g_arc_bridge_service = nullptr;
}
void ArcBridgeServiceImpl::RequestStart() {

Powered by Google App Engine
This is Rietveld 408576698