Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 255823009: [WIP] ui/window: Master CL.

Created:
6 years, 7 months ago by sadrul
Modified:
6 years, 7 months ago
Reviewers:
tfarina, spang
CC:
chromium-reviews, rjkroege, ozone-reviews_chromium.org, sadrul, tdresser+watch_chromium.org, Ian Vollick, jam, piman+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, kalyank, ben+aura_chromium.org, danakj+watch_chromium.org, stevenjb+watch_chromium.org, cc-bugs_chromium.org
Visibility:
Public.

Description

[WIP] ui/window: Master CL. The plan is to introduce a PlatformWindow concept, which takes care of creating and managing platform-dependent windows (e.g. Window on X11). It will have a PlatformWindowDelegate to relay information it receives from the platform to. The aura::WindowTreeHost becomes a concrete implementation, and the platform-specific implementations will be removed. Instead, the WindowTreeHost will own a PlatformWindow, and the WindowTreeHost becomes its PlatformWindowDelegate. In Ozone, a custom PlatformWindowCreator is installed that can create either an X11 window, or any other window etc. The X11 backend for ozone (ozonex) creates the X11 implementation of PlatformWindow, and so on. This PlatformWindow will also be used in mojo for the native_viewport. BUG=

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+697 lines, -61 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/chromeos.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/aura.gyp View 3 chunks +3 lines, -2 lines 0 comments Download
M ui/aura/env.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M ui/aura/window_tree_host_ozone.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/aura/window_tree_host_x11.h View 5 chunks +15 lines, -2 lines 0 comments Download
M ui/aura/window_tree_host_x11.cc View 5 chunks +50 lines, -0 lines 0 comments Download
M ui/compositor/compositor.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/events.gyp View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/events/ozone/evdev/event_factory_evdev.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/events/ozone/evdev/event_factory_evdev.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/ozone/event_factory_ozone.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/ozone/event_factory_ozone.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M ui/events/platform/x11/x11_event_source.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M ui/gfx/gfx.gyp View 2 chunks +1 line, -27 lines 0 comments Download
A ui/gfx/x/gfx_x11.gyp View 1 chunk +39 lines, -0 lines 0 comments Download
M ui/gl/gl.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/ozone.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A + ui/ozone/platform/ozonex/DEPS View 1 chunk +1 line, -1 line 0 comments Download
A ui/ozone/platform/ozonex/ozone_platform_ozonex.h View 1 chunk +19 lines, -0 lines 0 comments Download
A ui/ozone/platform/ozonex/ozone_platform_ozonex.cc View 1 chunk +117 lines, -0 lines 0 comments Download
A + ui/ozone/platform/ozonex/ozonex.gypi View 1 chunk +13 lines, -12 lines 0 comments Download
A + ui/window/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/window/platform_window.h View 1 chunk +68 lines, -0 lines 1 comment Download
A ui/window/window.gyp View 1 chunk +44 lines, -0 lines 1 comment Download
A ui/window/x11/x11_window.cc View 1 chunk +294 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
spang
I think it is best if ui/window depends on ui/ozone, so that we can avoid ...
6 years, 7 months ago (2014-04-28 16:41:31 UTC) #1
tfarina
Sadrul, could you add a brief README file to ui/window?
6 years, 7 months ago (2014-04-28 18:20:03 UTC) #2
tfarina
https://codereview.chromium.org/255823009/diff/1/ui/window/window.gyp File ui/window/window.gyp (right): https://codereview.chromium.org/255823009/diff/1/ui/window/window.gyp#newcode15 ui/window/window.gyp:15: '<(DEPTH)/base/base.gyp:base', please, do not add more usage of <(DEPTH) ...
6 years, 7 months ago (2014-04-28 18:20:52 UTC) #3
tfarina
6 years, 7 months ago (2014-04-28 18:22:37 UTC) #4
https://codereview.chromium.org/255823009/diff/1/ui/window/platform_window.h
File ui/window/platform_window.h (right):

https://codereview.chromium.org/255823009/diff/1/ui/window/platform_window.h#...
ui/window/platform_window.h:26: class PlatformWindowDelegate {
do you mind moving this to platform_window_delegate.h?

Powered by Google App Engine
This is Rietveld 408576698