Adds shift and capslock tests to IME Keyboard tests.

chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js

 /*
  * Copyright 2014 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 var mockController;
 var mockTimer;
 var setComposition;
 
 var DEFAULT_CONTEXT_ID = 1;
+var CAPSLOCK_ID = "OsLeft";
+
+/**
+ * Key alignments.
+ * @enum {string}
+ */
+var Alignment = {
+  LEFT: 'left',
+  RIGHT: 'right',
+  CENTER: 'center'
+}

[bshe, 2014/05/09 17:32:31]

nit: add ";" back.

[rsadam, 2014/05/09 18:17:39]

Done.

 
 /**
  * Create mocks for the virtualKeyboardPrivate API. Any tests that trigger API
  * calls must set expectations for call signatures.
  */
 function setUp() {
   mockController = new MockController();
   mockTimer = new MockTimer();
+  mockTimer.install();
 
-  mockTimer.install();
   mockController.createFunctionMock(chrome.input.ime, 'commitText');
-
   var validateCommit = function(index, expected, observed) {
     // Only consider the first argument, the details object.
     var expectedEvent = expected[0];
     var observedEvent = observed[0];
     assertEquals(expectedEvent.text,
                  observedEvent.text,
                  'Mismatched commit text.');
   };
   chrome.input.ime.commitText.validateCall = validateCommit;
+
   setComposition = chrome.input.ime.setComposition;
   // Mocks setComposition manually to immediately callback. The mock controller
   // does not support callback functions.
   chrome.input.ime.setComposition = function(obj, callback) {
     callback();
   }
   window.setContext({'contextID': DEFAULT_CONTEXT_ID, 'type': 'text'});
   // TODO(rsadam): Mock additional extension API calls as required.
 }
 
@@ skipping 20 matching lines @@
  * Generates a mouse event and dispatches it on the target.
  * @param target {Object} The target of the event.
  * @param type {String} The type of the mouse event.
  */
 function generateMouseEvent(target, type) {
   var e = new MouseEvent(type, {bubbles:true, cancelable:true});
   target.dispatchEvent(e);
 }
 
 /**
- * Mocks a character type using the mouse.
+ * Mocks a key type using the mouse.
+ * @param {Object} key The key to click on.
+ */
+function mockMouseTypeOnKey(key) {
+  generateMouseEvent(key, 'mouseover');
+  generateMouseEvent(key, 'mousedown');
+  generateMouseEvent(key, 'mouseup');
+  generateMouseEvent(key, 'click');
+  generateMouseEvent(key, 'mouseover');
+  generateMouseEvent(key, 'mouseout');
+}
+
+/**
+ * Mocks a character type using the mouse. Expects the character will be
+ * committed.
  * @param {String} char The character to type.
  */
 function mockMouseType(char) {
   var send = chrome.input.ime.commitText;
   send.addExpectation({
     contextId: DEFAULT_CONTEXT_ID,
     text: char,
   });
   var key = getKey(char);
   if (!key) {
     console.error("Cannot find key: " + char);

[bshe, 2014/05/09 17:32:31]

Do we have any case that key may be null? it looks like you can move this check
in getKey function.

[rsadam, 2014/05/09 18:17:39]

Nice catch! This was a refactoring mistake between the two patches. The key
should be never be null. Moved to getKey!

     return;
   }
-  generateMouseEvent(key, 'mouseover');
-  generateMouseEvent(key, 'mousedown');
-  generateMouseEvent(key, 'mouseup');
-  generateMouseEvent(key, 'click');
-  generateMouseEvent(key, 'mouseover');
-  generateMouseEvent(key, 'mouseout');
+  mockMouseTypeOnKey(key);
 }
+
+/**
+ * Generates a touch event and dispatches it on the target.
+ * @param target {Object} The target of the event.
+ * @param type {String} The type of the touch event.
+ */
+function generateTouchEvent(target, type) {
+  var e = document.createEvent('UIEvents');
+  e.initEvent(type, true, true);
+  target.dispatchEvent(e);
+}
+
+/**
+ * Mocks a character type using touch.
+ * @param {String} char The character to type.
+ */
+function mockTouchType(char) {
+  var send = chrome.input.ime.commitText;
+  send.addExpectation({
+    contextId: DEFAULT_CONTEXT_ID,
+    text: char,
+  });
+  var key = getKey(char);
+  generateTouchEvent(key, 'touchstart');
+  generateTouchEvent(key, 'touchend');
+}
+
+/**
+ * Retrieves the shift key from the current keyset.
+ * @param {Alignment} align The alignment of the shift key.
+ * @return {Object} The key.
+ */
+function getShiftKey(align) {
+  var id;
+  switch(align) {
+    case Alignment.LEFT:
+      id = 'ShiftLeft';
+      break;
+    case Alignment.RIGHT:
+      id = 'ShiftRight';
+      break;
+    default:
+      break;
+  }
+  assertTrue(!!id, "Invalid shift alignment option: " + align);
+  var shift = document.querySelector('#' + id);
+  assertTrue(!!shift, "Cannot find shift key with alignment: " + align);
+  return shift;
+}