Adds shift and capslock tests to IME Keyboard tests.

Adds shift and capslock tests to IME Keyboard tests.

To be landed after: https://codereview.chromium.org/247883002/ and https://codereview.chromium.org/259603002/

BUG=353857
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269521

[rsadam, 2014-04-25 15:48:24]

Hey Biao, PTAL!

[bshe, 2014-04-25 17:38:52]

https://codereview.chromium.org/255823004/diff/1/chrome/test/data/chromeos/vi...
File
chrome/test/data/chromeos/virtual_keyboard/inputview/keyset_transition_test.js
(right):

https://codereview.chromium.org/255823004/diff/1/chrome/test/data/chromeos/vi...
chrome/test/data/chromeos/virtual_keyboard/inputview/keyset_transition_test.js:6:

should mouse event also have test coverage?

https://codereview.chromium.org/255823004/diff/1/chrome/test/data/chromeos/vi...
chrome/test/data/chromeos/virtual_keyboard/inputview/keyset_transition_test.js:26:
var caps = document.querySelector('#' + CAPSLOCK_ID);
FYI: the default layout is going to switch to compact layout. Compact layout
doesn't have a caps lock by default. You may want to specifically navigate to
the full keyboard layout through URL hash for these tests.

[rsadam, 2014-04-28 19:10:04]

https://codereview.chromium.org/255823004/diff/1/chrome/test/data/chromeos/vi...
File
chrome/test/data/chromeos/virtual_keyboard/inputview/keyset_transition_test.js
(right):

https://codereview.chromium.org/255823004/diff/1/chrome/test/data/chromeos/vi...
chrome/test/data/chromeos/virtual_keyboard/inputview/keyset_transition_test.js:6:

On 2014/04/25 17:38:52, bshe wrote:
> should mouse event also have test coverage?

Done.

https://codereview.chromium.org/255823004/diff/1/chrome/test/data/chromeos/vi...
chrome/test/data/chromeos/virtual_keyboard/inputview/keyset_transition_test.js:26:
var caps = document.querySelector('#' + CAPSLOCK_ID);
On 2014/04/25 17:38:52, bshe wrote:
> FYI: the default layout is going to switch to compact layout. Compact layout
> doesn't have a caps lock by default. You may want to specifically navigate to
> the full keyboard layout through URL hash for these tests.

Thanks for the heads up! Will add this functionality after the slew of CL's i
have queued up are landed. Added a todo for now.

[bshe, 2014-04-28 19:40:10]

lgtm with nit

https://codereview.chromium.org/255823004/diff/40001/chrome/test/data/chromeo...
File
chrome/test/data/chromeos/virtual_keyboard/inputview/keyset_transition_test.js
(right):

https://codereview.chromium.org/255823004/diff/40001/chrome/test/data/chromeo...
chrome/test/data/chromeos/virtual_keyboard/inputview/keyset_transition_test.js:24:
// To upper case. TODO(rsadam@): Only test this for the full layout.
nit: move to TODO to next line

[rsadam, 2014-05-08 21:17:42]

Addressed nit!

The longpress test has some asynchronous behaviour that will need further
though, so it makes sense to land this one first. I moved the mockTouch methods
to this CL.

[bshe, 2014-05-09 17:32:31]

https://codereview.chromium.org/255823004/diff/120001/chrome/test/data/chrome...
File chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js (right):

https://codereview.chromium.org/255823004/diff/120001/chrome/test/data/chrome...
chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js:22: }
nit: add ";" back.

https://codereview.chromium.org/255823004/diff/120001/chrome/test/data/chrome...
chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js:109:
console.error("Cannot find key: " + char);
Do we have any case that key may be null? it looks like you can move this check
in getKey function.

[rsadam, 2014-05-09 18:17:38]

https://codereview.chromium.org/255823004/diff/120001/chrome/test/data/chrome...
File chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js (right):

https://codereview.chromium.org/255823004/diff/120001/chrome/test/data/chrome...
chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js:22: }
On 2014/05/09 17:32:31, bshe wrote:
> nit: add ";" back.

Done.

https://codereview.chromium.org/255823004/diff/120001/chrome/test/data/chrome...
chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js:109:
console.error("Cannot find key: " + char);
On 2014/05/09 17:32:31, bshe wrote:
> Do we have any case that key may be null? it looks like you can move this
check
> in getKey function.

Nice catch! This was a refactoring mistake between the two patches. The key
should be never be null. Moved to getKey!

[bshe, 2014-05-09 18:18:55]

On 2014/05/09 18:17:38, rsadam wrote:
>
https://codereview.chromium.org/255823004/diff/120001/chrome/test/data/chrome...
> File chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js
(right):
> 
>
https://codereview.chromium.org/255823004/diff/120001/chrome/test/data/chrome...
> chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js:22: }
> On 2014/05/09 17:32:31, bshe wrote:
> > nit: add ";" back.
> 
> Done.
> 
>
https://codereview.chromium.org/255823004/diff/120001/chrome/test/data/chrome...
> chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js:109:
> console.error("Cannot find key: " + char);
> On 2014/05/09 17:32:31, bshe wrote:
> > Do we have any case that key may be null? it looks like you can move this
> check
> > in getKey function.
> 
> Nice catch! This was a refactoring mistake between the two patches. The key
> should be never be null. Moved to getKey!

lgtm

[rsadam, 2014-05-09 18:31:18]

The CQ bit was checked by rsadam@chromium.org

[commit-bot: I haz the power, 2014-05-09 18:32:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rsadam@chromium.org/255823004/140001

[commit-bot: I haz the power, 2014-05-10 04:31:17]

Change committed as 269521