Expand clickable area of combobutton's dropdown indicator.

Expand clickable area of combobutton's dropdown indicator.

BUG=363540
TEST=manually tested.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266515

[fukino, 2014-04-25 07:41:41]

hirono san, could you take a look?
I attached screen shots which shows clickable area on crbug.com/363540.

[hirono, 2014-04-25 09:47:19]

Thank you!

https://codereview.chromium.org/255823002/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/css/combobutton.css (right):

https://codereview.chromium.org/255823002/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/css/combobutton.css:25: .buttonbar
.combobutton > .trigger:before {
nit: In files.app, we use '::' as a separator of pseudo elements such as
'before' and 'after'. ':' is for pseudo target such as 'hover'.

[fukino, 2014-04-25 09:57:08]

https://codereview.chromium.org/255823002/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/css/combobutton.css (right):

https://codereview.chromium.org/255823002/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/css/combobutton.css:25: .buttonbar
.combobutton > .trigger:before {
On 2014/04/25 09:47:19, hirono wrote:
> nit: In files.app, we use '::' as a separator of pseudo elements such as
> 'before' and 'after'. ':' is for pseudo target such as 'hover'.

Oops! I should have checked spec and grepped existing code.
Thank you for pointing it out!
Done.

[hirono, 2014-04-27 08:34:18]

On 2014/04/25 09:57:08, fukino wrote:
>
https://codereview.chromium.org/255823002/diff/1/ui/file_manager/file_manager...
> File ui/file_manager/file_manager/foreground/css/combobutton.css (right):
> 
>
https://codereview.chromium.org/255823002/diff/1/ui/file_manager/file_manager...
> ui/file_manager/file_manager/foreground/css/combobutton.css:25: .buttonbar
> .combobutton > .trigger:before {
> On 2014/04/25 09:47:19, hirono wrote:
> > nit: In files.app, we use '::' as a separator of pseudo elements such as
> > 'before' and 'after'. ':' is for pseudo target such as 'hover'.
> 
> Oops! I should have checked spec and grepped existing code.
> Thank you for pointing it out!
> Done.

Thank you. LGTM!

[fukino, 2014-04-28 01:14:38]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2014-04-28 01:15:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fukino@chromium.org/255823002/20001

[commit-bot: I haz the power, 2014-04-28 01:51:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 01:51:25]

Try jobs failed on following builders:
  tryserver.chromium on chromium_presubmit

[fukino, 2014-04-28 02:31:47]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2014-04-28 02:32:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fukino@chromium.org/255823002/20001

[commit-bot: I haz the power, 2014-04-28 03:18:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 03:18:02]

Try jobs failed on following builders:
  tryserver.chromium on chromium_presubmit

[fukino, 2014-04-28 03:26:37]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2014-04-28 03:27:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fukino@chromium.org/255823002/40001

[commit-bot: I haz the power, 2014-04-28 05:00:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 05:00:58]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_rel

[fukino, 2014-04-28 05:59:43]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2014-04-28 06:00:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fukino@chromium.org/255823002/40001

[commit-bot: I haz the power, 2014-04-28 12:11:53]

Change committed as 266515