android_webview/java/src/org/chromium/android_webview/AwServiceWorkerController.java - Issue 2558223002: Move onReceivedError and onReceivedHttpError out of AwContentsIoThreadClientImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwServiceWorkerController.java

Issue 2558223002: Move onReceivedError and onReceivedHttpError out of AwContentsIoThreadClientImpl (Closed)

Patch Set: add move assignment Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwContentsIoThreadClient.java ('k') | android_webview/native/aw_contents_client_bridge.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwServiceWorkerController.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwServiceWorkerController.java b/android_webview/java/src/org/chromium/android_webview/AwServiceWorkerController.java

index 532d6ca565bfaa71c93b2e9878cb9476216517f9..a73f6cc361e27918c074411133df833a4212071e 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwServiceWorkerController.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwServiceWorkerController.java

@@ -81,18 +81,6 @@ public class AwServiceWorkerController {

// see e.g. AwCookieAccessPolicy::GetShouldAcceptThirdPartyCookies.

return false;

}

- @Override

- public void onReceivedError(AwContentsClient.AwWebResourceRequest request,

- AwContentsClient.AwWebResourceError error) {

- // TODO

- }

- @Override

- public void onReceivedHttpError(AwContentsClient.AwWebResourceRequest request,

- AwWebResourceResponse response) {

- // TODO

- }

}

private class ServiceWorkerBackgroundThreadClientImpl