Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2558193002:
[Tracing] Support multi-categories group list. (Closed)
Description[Tracing] Support multi-categories group list.
jasongin@ created this patch.
https://github.com/jasongin/nodejs/commit/dcc50445a364664586164f42f9250732bd372982
This patch adds the support to emit a trace event by using a comma-separated
list of categories, so that the trace event will be emitted if there is at least
one category is enabled in the categories list.
TBR=jochen@chromium.org
Committed: https://crrev.com/ecdff43b99f40241b91f648f6b8f79c2e292ee41
Cr-Commit-Position: refs/heads/master@{#41567}
Patch Set 1 #Patch Set 2 : Add tests #
Messages
Total messages: 22 (15 generated)
The CQ bit was checked by lpy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lpy@chromium.org changed reviewers: + fmeawad@chromium.org, mattl@google.com - jochen@chromium.org
PTAL.
Description was changed from ========== [Tracing] Support multi-categories group list. jasongin@ created this patch. https://github.com/jasongin/nodejs/commit/dcc50445a364664586164f42f9250732bd3... This patch adds the support to emit a trace event by using a comma-separated list of categories, so that the trace event will be emitted if there is at least one category is enabled in the categories list. TBR=jochen@chromium.org ========== to ========== [Tracing] Support multi-categories group list. jasongin@ created this patch. https://github.com/jasongin/nodejs/commit/dcc50445a364664586164f42f9250732bd3... This patch adds the support to emit a trace event by using a comma-separated list of categories, so that the trace event will be emitted if there is at least one category is enabled in the categories list. TBR=jochen@chromium.org ==========
lpy@chromium.org changed reviewers: + mattloring@google.com - mattl@google.com
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Please add a test in test-tracing
The CQ bit was checked by lpy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/12/07 21:30:49, fmeawad wrote: > Please add a test in test-tracing done.
lgtm. Please monitor the benchmarks for any noticeable performance regression.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by lpy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481156738646830,
"parent_rev": "d4d748cdd698391f3054dfb7aff18beaa199e78c", "commit_rev":
"8822040249a251c66753e2146eba4f596d2f8777"}
Message was sent while issue was closed.
Description was changed from ========== [Tracing] Support multi-categories group list. jasongin@ created this patch. https://github.com/jasongin/nodejs/commit/dcc50445a364664586164f42f9250732bd3... This patch adds the support to emit a trace event by using a comma-separated list of categories, so that the trace event will be emitted if there is at least one category is enabled in the categories list. TBR=jochen@chromium.org ========== to ========== [Tracing] Support multi-categories group list. jasongin@ created this patch. https://github.com/jasongin/nodejs/commit/dcc50445a364664586164f42f9250732bd3... This patch adds the support to emit a trace event by using a comma-separated list of categories, so that the trace event will be emitted if there is at least one category is enabled in the categories list. TBR=jochen@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [Tracing] Support multi-categories group list. jasongin@ created this patch. https://github.com/jasongin/nodejs/commit/dcc50445a364664586164f42f9250732bd3... This patch adds the support to emit a trace event by using a comma-separated list of categories, so that the trace event will be emitted if there is at least one category is enabled in the categories list. TBR=jochen@chromium.org ========== to ========== [Tracing] Support multi-categories group list. jasongin@ created this patch. https://github.com/jasongin/nodejs/commit/dcc50445a364664586164f42f9250732bd3... This patch adds the support to emit a trace event by using a comma-separated list of categories, so that the trace event will be emitted if there is at least one category is enabled in the categories list. TBR=jochen@chromium.org Committed: https://crrev.com/ecdff43b99f40241b91f648f6b8f79c2e292ee41 Cr-Commit-Position: refs/heads/master@{#41567} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/ecdff43b99f40241b91f648f6b8f79c2e292ee41 Cr-Commit-Position: refs/heads/master@{#41567} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
